| Message ID | 1585879843-17731-3-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs-progs: fix issues in tests | expand |
On Fri, Apr 03, 2020 at 10:10:41AM +0800, Anand Jain wrote: > From > TEST_TOP="$TOP/tests/" > to > TEST_TOP="$TOP/tests" So this basically repeats the diff > Affected test cases are: > tests/clean-tests.sh > tests/cli-tests.sh > tests/convert-tests.sh > tests/fsck-tests.sh > tests/fuzz-tests.sh > tests/misc-tests.sh > tests/mkfs-tests.sh And this repeats the diffstat. The changelog should explain why the change is made, summarize some key points, etc. I'll apply this patch and write a changelog but please try to improve that. What works is to postpone sending the patches and read them after a day or two, if it still makes sense then send it. Second look reveals all the typos and missing information.
diff --git a/tests/clean-tests.sh b/tests/clean-tests.sh index eda16e329698..d8157ab54ee3 100755 --- a/tests/clean-tests.sh +++ b/tests/clean-tests.sh @@ -7,7 +7,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/cli-tests.sh b/tests/cli-tests.sh index d302a93ea594..d8cd06724701 100755 --- a/tests/cli-tests.sh +++ b/tests/cli-tests.sh @@ -8,7 +8,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/convert-tests.sh b/tests/convert-tests.sh index f6c940437eec..24b3ec0df144 100755 --- a/tests/convert-tests.sh +++ b/tests/convert-tests.sh @@ -9,7 +9,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/fsck-tests.sh b/tests/fsck-tests.sh index 8fbc2b4bc40e..15e3d8d5995c 100755 --- a/tests/fsck-tests.sh +++ b/tests/fsck-tests.sh @@ -8,7 +8,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/fuzz-tests.sh b/tests/fuzz-tests.sh index ae738710b8bc..0ba8f1e11f70 100755 --- a/tests/fuzz-tests.sh +++ b/tests/fuzz-tests.sh @@ -8,7 +8,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/misc-tests.sh b/tests/misc-tests.sh index 3e7b9e9befe6..3b49ab012e78 100755 --- a/tests/misc-tests.sh +++ b/tests/misc-tests.sh @@ -8,7 +8,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries diff --git a/tests/mkfs-tests.sh b/tests/mkfs-tests.sh index e76a805b4f0b..150f094f2303 100755 --- a/tests/mkfs-tests.sh +++ b/tests/mkfs-tests.sh @@ -8,7 +8,7 @@ if [ -z "$TOP" ]; then TOP=$(readlink -f "$SCRIPT_DIR/../") if [ -f "$TOP/configure.ac" ]; then # inside git - TEST_TOP="$TOP/tests/" + TEST_TOP="$TOP/tests" INTERNAL_BIN="$TOP" else # external, defaults to system binaries
From TEST_TOP="$TOP/tests/" to TEST_TOP="$TOP/tests" Affected test cases are: tests/clean-tests.sh tests/cli-tests.sh tests/convert-tests.sh tests/fsck-tests.sh tests/fuzz-tests.sh tests/misc-tests.sh tests/mkfs-tests.sh Signed-off-by: Anand Jain <anand.jain@oracle.com> --- tests/clean-tests.sh | 2 +- tests/cli-tests.sh | 2 +- tests/convert-tests.sh | 2 +- tests/fsck-tests.sh | 2 +- tests/fuzz-tests.sh | 2 +- tests/misc-tests.sh | 2 +- tests/mkfs-tests.sh | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)