diff mbox

btrfs-progs: Fix pointer math in __ino_to_path_fd

Message ID 20130214182950.GB31017@wotan.suse.de (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Mark Fasheh Feb. 14, 2013, 6:29 p.m. UTC
We are casting an array of u64 values into a char ** array so
when we dereference this array (as a char **) on a 32 bit system
we're then re-casting that back to a 32 bit value. This causes
problems when we try to print those strings.

Signed-off-by: Mark Fasheh <mfasheh@suse.de>
---
 cmds-inspect.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/cmds-inspect.c b/cmds-inspect.c
index 25b83d2..371bd34 100644
--- a/cmds-inspect.c
+++ b/cmds-inspect.c
@@ -61,12 +61,15 @@  static int __ino_to_path_fd(u64 inum, int fd, int verbose, const char *prepend)
 			fspath->elem_cnt, fspath->elem_missed);
 
 	for (i = 0; i < fspath->elem_cnt; ++i) {
-		char **str = (char **)fspath->val;
-		str[i] += (unsigned long)fspath->val;
+		u64 ptr;
+		char *str;
+		ptr = (u64)(unsigned long)fspath->val;
+		ptr += fspath->val[i];
+		str = (char *)(unsigned long)ptr;
 		if (prepend)
-			printf("%s/%s\n", prepend, str[i]);
+			printf("%s/%s\n", prepend, str);
 		else
-			printf("%s\n", str[i]);
+			printf("%s\n", str);
 	}
 
 out: