From patchwork Wed Jun 26 19:18:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zach Brown X-Patchwork-Id: 2787851 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C00CCC0AB1 for ; Wed, 26 Jun 2013 19:18:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7A23F2023E for ; Wed, 26 Jun 2013 19:18:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C88C201F0 for ; Wed, 26 Jun 2013 19:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506Ab3FZTSJ (ORCPT ); Wed, 26 Jun 2013 15:18:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58363 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912Ab3FZTSH (ORCPT ); Wed, 26 Jun 2013 15:18:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5QJI5RE013366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Jun 2013 15:18:05 -0400 Received: from localhost (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5QJI45P024622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 26 Jun 2013 15:18:05 -0400 Date: Wed, 26 Jun 2013 12:18:04 -0700 From: Zach Brown To: Josef Bacik Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, Eric Sandeen Subject: Re: [PATCH] xfstests: check if the scratch dev pool is mounted in _require_scratch Message-ID: <20130626191804.GA20692@lenny.home.zabbo.net> References: <1372261768-1795-1-git-send-email-jbacik@fusionio.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1372261768-1795-1-git-send-email-jbacik@fusionio.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > $SCRATCH_DEV, so anybody who wants to just use the scratch mnt with the scratch > dev will fail to work because we never unmount the scratch mount. Yeah, this is annoying. > Fix this by > checking to see if the scratch dev pool is mounted at scratch mnt and unmount it > so we can run our test. This fixes the issue I was seeing by running But this fix seems bonkers. Can we have _scratch_unmount unmount the mountpoint instead of the device? That's what Eric suggested when I whined about this a while ago. - z index fe6bbfc..481486a 100644 --- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/common/rc +++ b/common/rc @@ -280,7 +280,7 @@ _scratch_mount() _scratch_unmount() { - $UMOUNT_PROG $SCRATCH_DEV + $UMOUNT_PROG $SCRATCH_MNT } _scratch_remount()