From patchwork Tue Sep 22 17:54:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 7242241 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EE99BBEEC1 for ; Tue, 22 Sep 2015 17:55:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3299720A2A for ; Tue, 22 Sep 2015 17:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EDC820A29 for ; Tue, 22 Sep 2015 17:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933595AbbIVRzK (ORCPT ); Tue, 22 Sep 2015 13:55:10 -0400 Received: from mga03.intel.com ([134.134.136.65]:25967 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932906AbbIVRzH (ORCPT ); Tue, 22 Sep 2015 13:55:07 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 22 Sep 2015 10:55:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,574,1437462000"; d="scan'208";a="650186878" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga003.jf.intel.com with ESMTP; 22 Sep 2015 10:55:06 -0700 Received: from kbuild by bee with local (Exim 4.83) (envelope-from ) id 1ZeRmK-000JJD-TX; Wed, 23 Sep 2015 01:54:56 +0800 Date: Wed, 23 Sep 2015 01:54:26 +0800 From: kbuild test robot To: Mark Fasheh Cc: kbuild-all@01.org, Josef Bacik , linux-btrfs@vger.kernel.org Subject: [PATCH] fix ifnullfree.cocci warnings Message-ID: <20150922175426.GA62109@xian> References: <201509230124.0LoGc02q%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201509230124.0LoGc02q%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP fs/btrfs/qgroup.c:1463:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Mark Fasheh Signed-off-by: Fengguang Wu --- qgroup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -1459,8 +1459,7 @@ struct btrfs_qgroup_extent_record *btrfs void btrfs_qgroup_free_extent_record(struct btrfs_qgroup_extent_record *record) { - if (record) - kfree(record); + kfree(record); } struct btrfs_qgroup_extent_record