From patchwork Mon Jul 25 07:43:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoguang Wang X-Patchwork-Id: 9245309 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4658D60757 for ; Mon, 25 Jul 2016 07:46:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 364DE2621E for ; Mon, 25 Jul 2016 07:46:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2672326AE3; Mon, 25 Jul 2016 07:46:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE1C82621E for ; Mon, 25 Jul 2016 07:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbcGYHq2 (ORCPT ); Mon, 25 Jul 2016 03:46:28 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:50899 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751127AbcGYHq0 (ORCPT ); Mon, 25 Jul 2016 03:46:26 -0400 X-IronPort-AV: E=Sophos;i="5.20,367,1444665600"; d="scan'208";a="687148" Received: from unknown (HELO cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 25 Jul 2016 15:46:19 +0800 Received: from localhost.localdomain (unknown [10.167.226.107]) by cn.fujitsu.com (Postfix) with ESMTP id E505B4056401; Mon, 25 Jul 2016 15:46:18 +0800 (CST) From: Wang Xiaoguang To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org Subject: [PATCH v2] generic/371: run write(2) and fallocate(2) in parallel Date: Mon, 25 Jul 2016 15:43:30 +0800 Message-Id: <20160725074330.30081-1-wangxg.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 X-yoursite-MailScanner-ID: E505B4056401.A0C8B X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: wangxg.fnst@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently in btrfs, there is something wrong with fallocate(2)'s data space reservation, it'll temporarily occupy more data space thant it really needs, which in turn will impact other operations' data request. In this test case, it runs write(2) and fallocate(2) in parallel and the total needed data space for these two operations don't exceed whole fs free data space, to see whether we will get any unexpected ENOSPC error. Signed-off-by: Wang Xiaoguang --- v2: adopt Eryu Guan's suggestions to make this reproducer cleaner, thanks --- tests/generic/371 | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/371.out | 2 ++ tests/generic/group | 1 + 3 files changed, 78 insertions(+) create mode 100755 tests/generic/371 create mode 100644 tests/generic/371.out diff --git a/tests/generic/371 b/tests/generic/371 new file mode 100755 index 0000000..7955856 --- /dev/null +++ b/tests/generic/371 @@ -0,0 +1,75 @@ +#! /bin/bash +# FS QA Test 371 +# +# Run write(2) and fallocate(2) in parallel and the total needed data space +# for these operations don't exceed whole fs free data space, to see whether +# we will get any unexpected ENOSPC error. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch +_require_xfs_io_command "falloc" + +_scratch_mkfs_sized $((256 * 1024 * 1024)) >> $seqres.full 2>&1 +_scratch_mount + +testfile1=$SCRATCH_MNT/testfile1 +testfile2=$SCRATCH_MNT/testfile2 + +echo "Silence is golden" +for ((i=0; i<100; i++)); do + $XFS_IO_PROG -fc "pwrite 0 80M" $testfile1 >/dev/null + rm -f $testfile1 +done & +pids=$! + +for ((i=0; i<100; i++)); do + $XFS_IO_PROG -fc "falloc 0 80M" $testfile2 >/dev/null + rm -f $testfile2 +done & +pids="$pids $!" + +wait $pids +status=0 +exit diff --git a/tests/generic/371.out b/tests/generic/371.out new file mode 100644 index 0000000..22ec8a2 --- /dev/null +++ b/tests/generic/371.out @@ -0,0 +1,2 @@ +QA output created by 371 +Silence is golden diff --git a/tests/generic/group b/tests/generic/group index 97ecb65..1236281 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -373,3 +373,4 @@ 368 auto quick richacl 369 auto quick richacl 370 auto quick richacl +371 auto quick enospc prealloc