diff mbox

qgroup: Add trace events for reserve and free_ref_root

Message ID 20170219133037.20888-1-rgoldwyn@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Goldwyn Rodrigues Feb. 19, 2017, 1:30 p.m. UTC 
From: Goldwyn Rodrigues <rgoldwyn@suse.com>

These commits show the current value of qg->reserved and
the amount modified. Though these are frequently called function,
we may require to monitor qg->reserved for some operations.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
 fs/btrfs/qgroup.c            |  4 ++++
 include/trace/events/btrfs.h | 40 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)

Comments

Qu Wenruo Feb. 20, 2017, 3:02 a.m. UTC | #1 
At 02/19/2017 09:30 PM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> These commits show the current value of qg->reserved and
> the amount modified. Though these are frequently called function,
> we may require to monitor qg->reserved for some operations.

I have submitted similar patch for it before, while still not merged yet.
https://patchwork.kernel.org/patch/9453873/

And the latest version can be found in my qgroup fixes patchset.
https://github.com/adam900710/linux/tree/qgroup_fixes

Thanks,
Qu

>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
>  fs/btrfs/qgroup.c            |  4 ++++
>  include/trace/events/btrfs.h | 40 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index dfd9986..4700cac 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -2159,6 +2159,8 @@ static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes)
>
>  		qg = u64_to_ptr(unode->aux);
>
> +		trace_btrfs_qgroup_reserve(fs_info, qg->qgroupid, qg->reserved, num_bytes);
> +
>  		qg->reserved += num_bytes;
>  	}
>
> @@ -2204,6 +2206,8 @@ void btrfs_qgroup_free_refroot(struct btrfs_fs_info *fs_info,
>
>  		qg = u64_to_ptr(unode->aux);
>
> +		trace_btrfs_qgroup_free_refroot(fs_info, qg->qgroupid, qg->reserved, num_bytes);
> +
>  		qg->reserved -= num_bytes;
>
>  		list_for_each_entry(glist, &qg->groups, next_group) {
> diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
> index 6d7fe11..f6a9f8c 100644
> --- a/include/trace/events/btrfs.h
> +++ b/include/trace/events/btrfs.h
> @@ -1472,6 +1472,46 @@ TRACE_EVENT(qgroup_update_counters,
>  		  __entry->cur_new_count)
>  );
>
> +DECLARE_EVENT_CLASS(btrfs_qgroup_reserved,
> +
> +	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid,
> +		 u64 reserved, u64 num_bytes),
> +
> +	TP_ARGS(fs_info, qgid, reserved, num_bytes),
> +
> +	TP_STRUCT__entry_btrfs(
> +		__field(	u64,  qgid			)
> +		__field(	u64,  reserved		)
> +		__field(	u64,  num_bytes		)
> +	),
> +
> +	TP_fast_assign_btrfs(fs_info,
> +		__entry->qgid		= qgid;
> +		__entry->reserved	= reserved;
> +		__entry->num_bytes	= num_bytes;
> +	),
> +
> +	TP_printk_btrfs("qgid = %llu, reserved = %llu, num_bytes = %llu",
> +		  __entry->qgid,
> +		  __entry->reserved,
> +		  __entry->num_bytes)
> +);
> +
> +
> +DEFINE_EVENT(btrfs_qgroup_reserved, btrfs_qgroup_reserve,
> +
> +	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid, u64 reserved, u64 num_bytes),
> +
> +	TP_ARGS(fs_info, qgid, reserved, num_bytes)
> +);
> +
> +DEFINE_EVENT(btrfs_qgroup_reserved, btrfs_qgroup_free_refroot,
> +
> +	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid, u64 reserved, u64 num_bytes),
> +
> +	TP_ARGS(fs_info, qgid, reserved, num_bytes)
> +);
> +
>  #endif /* _TRACE_BTRFS_H */
>
>  /* This part must be outside protection */
>


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index dfd9986..4700cac 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -2159,6 +2159,8 @@  static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes)
 
 		qg = u64_to_ptr(unode->aux);
 
+		trace_btrfs_qgroup_reserve(fs_info, qg->qgroupid, qg->reserved, num_bytes);
+
 		qg->reserved += num_bytes;
 	}
 
@@ -2204,6 +2206,8 @@  void btrfs_qgroup_free_refroot(struct btrfs_fs_info *fs_info,
 
 		qg = u64_to_ptr(unode->aux);
 
+		trace_btrfs_qgroup_free_refroot(fs_info, qg->qgroupid, qg->reserved, num_bytes);
+
 		qg->reserved -= num_bytes;
 
 		list_for_each_entry(glist, &qg->groups, next_group) {
diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index 6d7fe11..f6a9f8c 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -1472,6 +1472,46 @@  TRACE_EVENT(qgroup_update_counters,
 		  __entry->cur_new_count)
 );
 
+DECLARE_EVENT_CLASS(btrfs_qgroup_reserved,
+
+	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid,
+		 u64 reserved, u64 num_bytes),
+
+	TP_ARGS(fs_info, qgid, reserved, num_bytes),
+
+	TP_STRUCT__entry_btrfs(
+		__field(	u64,  qgid			)
+		__field(	u64,  reserved		)
+		__field(	u64,  num_bytes		)
+	),
+
+	TP_fast_assign_btrfs(fs_info,
+		__entry->qgid		= qgid;
+		__entry->reserved	= reserved;
+		__entry->num_bytes	= num_bytes;
+	),
+
+	TP_printk_btrfs("qgid = %llu, reserved = %llu, num_bytes = %llu",
+		  __entry->qgid,
+		  __entry->reserved,
+		  __entry->num_bytes)
+);
+
+
+DEFINE_EVENT(btrfs_qgroup_reserved, btrfs_qgroup_reserve,
+
+	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid, u64 reserved, u64 num_bytes),
+
+	TP_ARGS(fs_info, qgid, reserved, num_bytes)
+);
+
+DEFINE_EVENT(btrfs_qgroup_reserved, btrfs_qgroup_free_refroot,
+
+	TP_PROTO(struct btrfs_fs_info *fs_info, u64 qgid, u64 reserved, u64 num_bytes),
+
+	TP_ARGS(fs_info, qgid, reserved, num_bytes)
+);
+
 #endif /* _TRACE_BTRFS_H */
 
 /* This part must be outside protection */