diff mbox

btrfs-progs: send-dump: add missing newlines

Message ID 20170222213246.29315-1-benedikt.morbach@googlemail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Benedikt Morbach Feb. 22, 2017, 9:32 p.m. UTC
make sure to include newlines after commands that have only one
argument, such as 'unlink' or 'mkfile'

changes

    unlink          ./baz.0/file_autimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
    truncate        ./baz.0/file_a                  size=131072
    chmod           ./baz.0/file_a                  mode=644
    utimes          ./baz.0/file_a                  atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
    mkfile          ./baz.0/o258-11-0rename          ./baz.0/o258-11-0               dest=./baz.0/file_b
    utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100

to

    unlink          ./baz.0/file_a
    utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
    truncate        ./baz.0/file_a                  size=131072
    chmod           ./baz.0/file_a                  mode=644
    utimes          ./baz.0/file_a                  atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
    mkfile          ./baz.0/o258-11-0
    rename          ./baz.0/o258-11-0               dest=./baz.0/file_b
    utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100

Signed-off-by: Benedikt Morbach <benedikt.morbach@googlemail.com>
---
 send-dump.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

David Sterba March 1, 2017, 2:59 p.m. UTC | #1
On Wed, Feb 22, 2017 at 10:32:46PM +0100, Benedikt Morbach wrote:
> make sure to include newlines after commands that have only one
> argument, such as 'unlink' or 'mkfile'
> 
> changes
> 
>     unlink          ./baz.0/file_autimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
>     truncate        ./baz.0/file_a                  size=131072
>     chmod           ./baz.0/file_a                  mode=644
>     utimes          ./baz.0/file_a                  atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
>     mkfile          ./baz.0/o258-11-0rename          ./baz.0/o258-11-0               dest=./baz.0/file_b
>     utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
> 
> to
> 
>     unlink          ./baz.0/file_a
>     utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
>     truncate        ./baz.0/file_a                  size=131072
>     chmod           ./baz.0/file_a                  mode=644
>     utimes          ./baz.0/file_a                  atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
>     mkfile          ./baz.0/o258-11-0
>     rename          ./baz.0/o258-11-0               dest=./baz.0/file_b
>     utimes          ./baz.0/                        atime=2017-02-22T11:59:16+0100 mtime=2017-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100
> 
> Signed-off-by: Benedikt Morbach <benedikt.morbach@googlemail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/send-dump.c b/send-dump.c
index 4c44246..67f7977 100644
--- a/send-dump.c
+++ b/send-dump.c
@@ -112,8 +112,10 @@  static int __print_dump(int subvol, void *user, const char *path,
 	/* Unified header */
 	printf("%-16s", title);
 	ret = print_path_escaped(out_path);
-	if (!fmt)
+	if (!fmt) {
+		putchar('\n');
 		return 0;
+	}
 	/* Short paths ale aligned to 32 chars */
 	while (ret++ < 32)
 		putchar(' ');