From patchwork Tue Mar 7 02:29:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Bo X-Patchwork-Id: 9608013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58611602B4 for ; Tue, 7 Mar 2017 02:36:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3495E28489 for ; Tue, 7 Mar 2017 02:36:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 21AF92848D; Tue, 7 Mar 2017 02:36:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AEA4D2845E for ; Tue, 7 Mar 2017 02:36:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753906AbdCGCcB (ORCPT ); Mon, 6 Mar 2017 21:32:01 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:36885 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbdCGCb7 (ORCPT ); Mon, 6 Mar 2017 21:31:59 -0500 Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by userp1050.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v272V6pQ009563 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 7 Mar 2017 02:31:06 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v272TtwA010050 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Mar 2017 02:29:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v272Tr7G006450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Mar 2017 02:29:54 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v272TqlF011192; Tue, 7 Mar 2017 02:29:52 GMT Received: from lim.localdomain (/10.154.140.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 06 Mar 2017 18:29:52 -0800 Date: Mon, 6 Mar 2017 18:29:29 -0800 From: Liu Bo To: Dave Jones Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: assertion failed: page_ops & PAGE_LOCK Message-ID: <20170307022929.GA11113@lim.localdomain> Reply-To: bo.li.liu@oracle.com References: <20170305165917.2epbvdtulalrfxc3@codemonkey.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170305165917.2epbvdtulalrfxc3@codemonkey.org.uk> User-Agent: Mutt/1.8.0 (2017-02-23) X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Mar 05, 2017 at 11:59:17AM -0500, Dave Jones wrote: > After commenting out the assertion that Liu bo pointed out was bogus, > my trinity runs last a little longer.. This is a new one I think.. > Could you please try this patch? Thanks, -liubo > assertion failed: page_ops & PAGE_LOCK, file: fs/btrfs/extent_io.c, line: 1716 > ------------[ cut here ]------------ > kernel BUG at fs/btrfs/ctree.h:3423! > invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC > CPU: 1 PID: 32625 Comm: trinity-c40 Not tainted 4.10.0-think+ #3 > task: ffff8804c6b95440 task.stack: ffffc90000ba8000 > RIP: 0010:assfail.constprop.68+0x1c/0x1e > RSP: 0018:ffffc90000bab6c0 EFLAGS: 00010282 > RAX: 000000000000004e RBX: 00000000000000a3 RCX: 0000000000000001 > RDX: 0000000000000000 RSI: ffffffff81ee593a RDI: 00000000ffffffff > RBP: ffffc90000bab6c0 R08: 0000000000000000 R09: 0000000000000001 > R10: 0000000000000001 R11: 0000000000000000 R12: ffffc90000bab790 > R13: 0000000000000000 R14: 00000000000001f8 R15: ffffea000b2026c0 > FS: 00007f102a0e4b40(0000) GS:ffff880507a00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f1029f21000 CR3: 00000004c6bde000 CR4: 00000000001406e0 > DR0: 00007f695d948000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600 > Call Trace: > __process_pages_contig+0x4b4/0x4d0 > __unlock_for_delalloc.isra.43+0x32/0x50 > find_lock_delalloc_range+0x15e/0x210 > writepage_delalloc.isra.51+0x91/0x1a0 > __extent_writepage+0x10d/0x470 > extent_write_cache_pages.constprop.57+0x2d3/0x430 > extent_writepages+0x5d/0x90 > ? btrfs_releasepage+0x20/0x20 > btrfs_writepages+0x28/0x30 > do_writepages+0x21/0x30 > __filemap_fdatawrite_range+0xc6/0x100 > filemap_fdatawrite_range+0x13/0x20 > btrfs_fdatawrite_range+0x20/0x50 > start_ordered_ops+0x19/0x30 > btrfs_sync_file+0x99/0x540 > ? debug_smp_processor_id+0x17/0x20 > ? get_lock_stats+0x19/0x50 > ? debug_smp_processor_id+0x17/0x20 > ? get_lock_stats+0x19/0x50 > vfs_fsync_range+0x4b/0xb0 > btrfs_file_write_iter+0x412/0x570 > ? rcu_sync_lockdep_assert+0x2f/0x60 > __do_readv_writev+0x2ea/0x380 > do_readv_writev+0x7c/0xc0 > ? debug_smp_processor_id+0x17/0x20 > ? get_lock_stats+0x19/0x50 > ? __context_tracking_exit.part.5+0x82/0x1e0 > vfs_writev+0x3f/0x50 > do_pwritev+0xb5/0xd0 > SyS_pwritev2+0x17/0x30 > do_syscall_64+0x66/0x1d0 > entry_SYSCALL64_slow_path+0x25/0x25 > RIP: 0033:0x7f1029a0e0f9 > RSP: 002b:00007ffe59e72c48 EFLAGS: 00000246 > [CONT START] ORIG_RAX: 0000000000000148 > RAX: ffffffffffffffda RBX: 0000000000000148 RCX: 00007f1029a0e0f9 > RDX: 00000000000000f2 RSI: 0000562b5ef7de50 RDI: 0000000000000185 > RBP: 00007f1029fc5000 R08: 000008002180528a R09: 0000000000000007 > R10: 000000000000baba R11: 0000000000000246 R12: 0000000000000002 > R13: 00007f1029fc5048 R14: 00007f102a0e4ad8 R15: 00007f1029fc5000 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 28e8192..8df7974 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -1714,7 +1714,8 @@ static int __process_pages_contig(struct address_space *mapping, * can we find nothing at @index. */ ASSERT(page_ops & PAGE_LOCK); - return ret; + err = -EAGAIN; + goto out; } for (i = 0; i < ret; i++) {