| Message ID | 20170406032253.14631-7-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 06, 2017 at 11:22:52AM +0800, Anand Jain wrote: > The last consumer of nobarriers is removed by the commit [1] and sync > won't fail with EOPNOTSUPP anymore. Thus, now when write cache is write > through it just return success without actually transpiring such a > request to the block device/lun. > > [1] > commit b25de9d6da49b1a8760a89672283128aa8c78345 > block: remove BIO_EOPNOTSUPP > > And, as the device/lun write cache state may change dynamically saving > such as state won't help either. So deleting the member nobarriers. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: David Sterba <dsterba@suse.com> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 3c476b118440..b6d047250ce2 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3517,9 +3517,6 @@ static void btrfs_dev_issue_flush(struct work_struct *work) */ static int write_dev_flush(struct btrfs_device *device, int wait) { - if (device->nobarriers) - return 0; - if (wait) { int ret; diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h index 0df50bc65578..1168b78c5f1d 100644 --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -123,7 +123,6 @@ struct btrfs_device { struct list_head resized_list; /* for sending down flush barriers */ - int nobarriers; struct completion flush_wait; struct work_struct flush_work; int last_flush_error;
The last consumer of nobarriers is removed by the commit [1] and sync won't fail with EOPNOTSUPP anymore. Thus, now when write cache is write through it just return success without actually transpiring such a request to the block device/lun. [1] commit b25de9d6da49b1a8760a89672283128aa8c78345 block: remove BIO_EOPNOTSUPP And, as the device/lun write cache state may change dynamically saving such as state won't help either. So deleting the member nobarriers. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- v2: add commit log. ref of last consumer. v3: nochange v4: nochange fs/btrfs/disk-io.c | 3 --- fs/btrfs/volumes.h | 1 - 2 files changed, 4 deletions(-)