[1/2] Btrfs: use cached state when dirtying pages during buffered write

Commit Message

Filipe Manana Oct. 31, 2017, 6:55 p.m. UTC

From: Filipe Manana <[e-mail]>

During a buffered IO write, we can have an extent state that we got when
we locked the range (if the range starts at an offset lower than eof), so
always pass it to btrfs_dirty_pages() so that setting the delalloc bit
in the range does not need to do a full search in the inode's io tree,
saving time and reducing the amount of time we hold the io tree's lock.

Signed-off-by: Filipe Manana <[e-mail]>
---
 fs/btrfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba Nov. 6, 2017, 3:50 p.m. UTC | #1

On Tue, Oct 31, 2017 at 06:55:40PM +0000, [e-mail] wrote:
> From: Filipe Manana <[e-mail]>
> 
> During a buffered IO write, we can have an extent state that we got when
> we locked the range (if the range starts at an offset lower than eof), so
> always pass it to btrfs_dirty_pages() so that setting the delalloc bit
> in the range does not need to do a full search in the inode's io tree,
> saving time and reducing the amount of time we hold the io tree's lock.
> 
> Signed-off-by: Filipe Manana <[e-mail]>

Reviewed-by: David Sterba <[e-mail]>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index e0d15c0d1641..aaab1838cece 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1755,7 +1755,7 @@  static noinline ssize_t __btrfs_buffered_write(struct file *file,
 
 		if (copied > 0)
 			ret = btrfs_dirty_pages(inode, pages, dirty_pages,
-						pos, copied, NULL);
+						pos, copied, &cached_state);
 		if (need_unlock)
 			unlock_extent_cached(&BTRFS_I(inode)->io_tree,
 					     lockstart, lockend, &cached_state,