| Message ID | 20180130074039.24987-2-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c > index e9c31b567a9c..6e1128aa29d6 100644 > --- a/fs/btrfs/extent-tree.c > +++ b/fs/btrfs/extent-tree.c > @@ -7346,7 +7346,8 @@ wait_block_group_cache_done(struct btrfs_block_group_cache *cache) > return ret; > } > > -int get_block_group_index(struct btrfs_block_group_cache *cache) > +static enum btrfs_raid_types > +get_block_group_index(struct btrfs_block_group_cache *cache) > { > return btrfs_bg_flags_to_raid_index(cache->flags); > } This changed should rather be part of 1/3. Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30.01.2018 09:40, Qu Wenruo wrote: > That function is only used inside extent-tree.c. > > Signed-off-by: Qu Wenruo <wqu@suse.com> > --- > fs/btrfs/ctree.h | 1 - > fs/btrfs/extent-tree.c | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index 13c260b525a1..27249240fa3e 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -2629,7 +2629,6 @@ struct btrfs_block_group_cache *btrfs_lookup_block_group( > u64 bytenr); > void btrfs_get_block_group(struct btrfs_block_group_cache *cache); > void btrfs_put_block_group(struct btrfs_block_group_cache *cache); > -int get_block_group_index(struct btrfs_block_group_cache *cache); > struct extent_buffer *btrfs_alloc_tree_block(struct btrfs_trans_handle *trans, > struct btrfs_root *root, > u64 parent, u64 root_objectid, > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c > index e9c31b567a9c..6e1128aa29d6 100644 > --- a/fs/btrfs/extent-tree.c > +++ b/fs/btrfs/extent-tree.c > @@ -7346,7 +7346,8 @@ wait_block_group_cache_done(struct btrfs_block_group_cache *cache) > return ret; > } > > -int get_block_group_index(struct btrfs_block_group_cache *cache) > +static enum btrfs_raid_types > +get_block_group_index(struct btrfs_block_group_cache *cache) > { > return btrfs_bg_flags_to_raid_index(cache->flags); > } I'd rather you removed this function and used bg_flags_to_raid_index directly. Otherwise we have yet another level of indirection with a rather wrong name - "block_group_index" ? > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018年01月30日 16:18, Nikolay Borisov wrote: > > > On 30.01.2018 09:40, Qu Wenruo wrote: >> That function is only used inside extent-tree.c. >> >> Signed-off-by: Qu Wenruo <wqu@suse.com> >> --- >> fs/btrfs/ctree.h | 1 - >> fs/btrfs/extent-tree.c | 3 ++- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h >> index 13c260b525a1..27249240fa3e 100644 >> --- a/fs/btrfs/ctree.h >> +++ b/fs/btrfs/ctree.h >> @@ -2629,7 +2629,6 @@ struct btrfs_block_group_cache *btrfs_lookup_block_group( >> u64 bytenr); >> void btrfs_get_block_group(struct btrfs_block_group_cache *cache); >> void btrfs_put_block_group(struct btrfs_block_group_cache *cache); >> -int get_block_group_index(struct btrfs_block_group_cache *cache); >> struct extent_buffer *btrfs_alloc_tree_block(struct btrfs_trans_handle *trans, >> struct btrfs_root *root, >> u64 parent, u64 root_objectid, >> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c >> index e9c31b567a9c..6e1128aa29d6 100644 >> --- a/fs/btrfs/extent-tree.c >> +++ b/fs/btrfs/extent-tree.c >> @@ -7346,7 +7346,8 @@ wait_block_group_cache_done(struct btrfs_block_group_cache *cache) >> return ret; >> } >> >> -int get_block_group_index(struct btrfs_block_group_cache *cache) >> +static enum btrfs_raid_types >> +get_block_group_index(struct btrfs_block_group_cache *cache) >> { >> return btrfs_bg_flags_to_raid_index(cache->flags); >> } > > I'd rather you removed this function and used bg_flags_to_raid_index > directly. Otherwise we have yet another level of indirection with a > rather wrong name - "block_group_index" ? Right, also pointed out by Anand, I'll just remove it. Thanks, Qu > >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 13c260b525a1..27249240fa3e 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -2629,7 +2629,6 @@ struct btrfs_block_group_cache *btrfs_lookup_block_group( u64 bytenr); void btrfs_get_block_group(struct btrfs_block_group_cache *cache); void btrfs_put_block_group(struct btrfs_block_group_cache *cache); -int get_block_group_index(struct btrfs_block_group_cache *cache); struct extent_buffer *btrfs_alloc_tree_block(struct btrfs_trans_handle *trans, struct btrfs_root *root, u64 parent, u64 root_objectid, diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e9c31b567a9c..6e1128aa29d6 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -7346,7 +7346,8 @@ wait_block_group_cache_done(struct btrfs_block_group_cache *cache) return ret; } -int get_block_group_index(struct btrfs_block_group_cache *cache) +static enum btrfs_raid_types +get_block_group_index(struct btrfs_block_group_cache *cache) { return btrfs_bg_flags_to_raid_index(cache->flags); }
That function is only used inside extent-tree.c. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/btrfs/ctree.h | 1 - fs/btrfs/extent-tree.c | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-)