| Message ID | 20180213132509.GA16525@drobertson-crashbox.lab.tripwire.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 13, 2018 at 01:25:10PM +0000, Dan Robertson wrote: > Ensure that limits.h is included in mkfs/main.c as PATH_MAX is used. The lack > of this currently causes btrfs-progs to fail to compile when the systems libc > is musl. > From 7859e0d01778e844ae0fcbefe55581277ce7cab3 Mon Sep 17 00:00:00 2001 > From: Dan Robertson <danlrobertson89@gmail.com> > Date: Tue, 13 Feb 2018 13:04:29 +0000 > Subject: [PATCH] btrfs-progs: compile with musl libc > > Ensure that limits.h is included in mkfs/main.c as PATH_MAX is used. > > Signed-off-by: Dan Robertson <danlrobertson89@gmail.com> Thanks, this has been fixed in https://github.com/kdave/btrfs-progs/commit/3aa1bbdd89ee9c9c48d260a6192fae08328f1b2f and the musl build check is now in place so the breakage should not happen anymore. I'll do a release this week with the fix included. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Thanks, this has been fixed in > https://github.com/kdave/btrfs-progs/commit/3aa1bbdd89ee9c9c48d260a6192fae08328f1b2f Ah, my bad. Didn't check the dev branch. Thanks for the quick response! Cheers, Dan
From 7859e0d01778e844ae0fcbefe55581277ce7cab3 Mon Sep 17 00:00:00 2001 From: Dan Robertson <danlrobertson89@gmail.com> Date: Tue, 13 Feb 2018 13:04:29 +0000 Subject: [PATCH] btrfs-progs: compile with musl libc Ensure that limits.h is included in mkfs/main.c as PATH_MAX is used. Signed-off-by: Dan Robertson <danlrobertson89@gmail.com> --- mkfs/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mkfs/main.c b/mkfs/main.c index ea65c6d8..f44520aa 100644 --- a/mkfs/main.c +++ b/mkfs/main.c @@ -27,6 +27,7 @@ /* #include <sys/dir.h> included via androidcompat.h */ #include <fcntl.h> #include <unistd.h> +#include <limits.h> #include <getopt.h> #include <uuid/uuid.h> #include <ctype.h> -- 2.16.1