From patchwork Tue May 8 05:48:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lu Fengqi X-Patchwork-Id: 10385399 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CAC79602C2 for ; Tue, 8 May 2018 05:48:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A2FF2817F for ; Tue, 8 May 2018 05:48:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F04228C79; Tue, 8 May 2018 05:48:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A940D2817F for ; Tue, 8 May 2018 05:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753971AbeEHFsX (ORCPT ); Tue, 8 May 2018 01:48:23 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:6052 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752214AbeEHFsU (ORCPT ); Tue, 8 May 2018 01:48:20 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="39676238" Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 08 May 2018 13:48:13 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 5FC554B34D40 for ; Tue, 8 May 2018 13:48:12 +0800 (CST) Received: from fnst.localdomain (10.167.226.155) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 8 May 2018 13:48:14 +0800 From: Lu Fengqi To: Subject: [PATCH 2/2] btrfs-progs: tests: check btrfs qgroup parent-child relation output Date: Tue, 8 May 2018 13:48:03 +0800 Message-ID: <20180508054803.20851-2-lufq.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180508054803.20851-1-lufq.fnst@cn.fujitsu.com> References: <20180508054803.20851-1-lufq.fnst@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.155] X-yoursite-MailScanner-ID: 5FC554B34D40.AB564 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lufq.fnst@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since commit aaf2dac5ef37 ("btrfs-progs: qgroup: split update_qgroup to reduce arguments") cause qgroup show to output the wrong qgroup parent-child relationship, in addition to fixing the problem, a test case is needed to prevent the similar problem in the future. Signed-off-by: Lu Fengqi Reviewed-by: Qu Wenruo --- .../031-qgroup-parent-child-relation/test.sh | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100755 tests/misc-tests/031-qgroup-parent-child-relation/test.sh diff --git a/tests/misc-tests/031-qgroup-parent-child-relation/test.sh b/tests/misc-tests/031-qgroup-parent-child-relation/test.sh new file mode 100755 index 000000000000..5be32aef58d9 --- /dev/null +++ b/tests/misc-tests/031-qgroup-parent-child-relation/test.sh @@ -0,0 +1,27 @@ +#!/bin/bash +# Test that btrfs qgroup show output the correct parent-child qgroup relation + +source "$TEST_TOP/common" + +check_prereq mkfs.btrfs +check_prereq btrfs + +setup_root_helper +prepare_test_dev + +run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$TEST_DEV" +run_check_mount_test_dev + +run_check $SUDO_HELPER "$TOP/btrfs" quota enable "$TEST_MNT" +run_check $SUDO_HELPER "$TOP/btrfs" qgroup create 1/0 "$TEST_MNT" +run_check $SUDO_HELPER "$TOP/btrfs" qgroup assign 0/5 1/0 "$TEST_MNT" +run_check $SUDO_HELPER "$TOP/btrfs" quota rescan -w "$TEST_MNT" + +run_check_stdout $SUDO_HELPER "$TOP/btrfs" qgroup show --sort=-qgroupid \ + -p "$TEST_MNT" | tail -n 1 | grep -q "1/0" \ + || _fail "parent qgroup check failed, please check the log" +run_check_stdout $SUDO_HELPER "$TOP/btrfs" qgroup show --sort=qgroupid \ + -c "$TEST_MNT" | tail -n 1 | grep -q "0/5" \ + || _fail "child qgroup check failed, please check the log" + +run_check_umount_test_dev "$TEST_MNT"