| Message ID | 20180719145006.17532-15-josef@toxicpanda.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 19, 2018 at 10:49:59AM -0400, Josef Bacik wrote: > We want to have a complete picture of any delayed inode updates before > we make the decision to commit or not, so make sure we run delayed iputs > before making the decision to commit or not. This basically says "we need to do X, so we do X", lacking the explanation why.
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 355884445f38..81396bac53f1 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -4923,6 +4923,10 @@ static int may_commit_transaction(struct btrfs_fs_info *fs_info, goto commit; } + mutex_lock(&fs_info->cleaner_delayed_iput_mutex); + btrfs_run_delayed_iputs(fs_info); + mutex_unlock(&fs_info->cleaner_delayed_iput_mutex); + spin_lock(&delayed_rsv->lock); reclaim_bytes += delayed_rsv->reserved; spin_unlock(&delayed_rsv->lock);
We want to have a complete picture of any delayed inode updates before we make the decision to commit or not, so make sure we run delayed iputs before making the decision to commit or not. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/btrfs/extent-tree.c | 4 ++++ 1 file changed, 4 insertions(+)