From patchwork Thu Aug 30 17:42:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10582469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1515E17DE for ; Thu, 30 Aug 2018 17:43:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0468F284DA for ; Thu, 30 Aug 2018 17:43:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED14328676; Thu, 30 Aug 2018 17:43:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 98AC6284DA for ; Thu, 30 Aug 2018 17:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbeH3VqZ (ORCPT ); Thu, 30 Aug 2018 17:46:25 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:45111 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbeH3VqZ (ORCPT ); Thu, 30 Aug 2018 17:46:25 -0400 Received: by mail-qt0-f194.google.com with SMTP id g44-v6so11259148qtb.12 for ; Thu, 30 Aug 2018 10:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=Er/itZiSy6nL1jO5ftCZDD3fOMgMo4baPf1MXLpwYlU=; b=L9g3QdeAlQRJMCcykGe0dRaSNvNoYKzARQbAHELjWaNTTTJUAjTesBRiTxFrtRqXLA L6ipqyCvBkL4eUji20GTmRVPR5y+OcfJVUZHyFbX/wZQUHTcyNRdGQsSF9h37eBzaVyx koCz4SpFbhM5y9pnfEm3Maz+Qx4KgTlCzWsWX+qn8/IoAkk6YncOhF2t78mA3SOwKsFd KvU3pzq4wcu3rZUYHwoAuBaF4W5ceuFJ4nKPFQn/7AFn5r2UUSxTstlrJOJAEUccUPfH XAdpe6uDNOR+9jjXx9sbB5H78rKH2eIn1FCngjzsgiC90g9hmkdHm7LlEOcgdHXo4Kju 79vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Er/itZiSy6nL1jO5ftCZDD3fOMgMo4baPf1MXLpwYlU=; b=aovWQkQOpXxQ0ShyPf6bZ4ghxXefArhBjKjF3DsHjuO8hJ0uyxJIib7mCuyBjmXrAP 1qaJMl8x2Zqx+fPQVlHAozAZ9lEa3ey5oJt7K43P4M05zDNUL8uVtzw6mrS/gQZnheuu L5X50iKyS93UWctmod4j74saPPY1deouoZfIYnSaDj1SacpGII3qjYGRvbDJLCCX+y2e HLYuRoa7cmvPVyjePaYBgHxiR6S0QONj/6zJ8CxOzzu5KE7XDuI+ANNdJDcNKTkjhWJi y4fZaoPfbvmxMPKT6tjmGVcoh2U64kxts4V94npfVbUG4pUVhHvDiKlU/YDHzkNaO8eq vsMg== X-Gm-Message-State: APzg51D8Np8V2crdzKJDQfpWXLjK7SeTttNtaT3UHGbANYw80DmSvZzo DqDwiVFeSYPP25I2tHO1iOnJkcVAFSF2pg== X-Google-Smtp-Source: ANB0VdagLg3cj0x/jSxPZdlANDb0zhL6mmBcG2RWmpYCPe4UG6MjUZirtSjdp5l/8fqBt63YOj7svA== X-Received: by 2002:ae9:f10c:: with SMTP id k12-v6mr12282744qkg.342.1535650989723; Thu, 30 Aug 2018 10:43:09 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id a10-v6sm240861qkj.60.2018.08.30.10.43.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Aug 2018 10:43:08 -0700 (PDT) From: Josef Bacik To: linux-btrfs@vger.kernel.org Subject: [PATCH 23/35] btrfs: assert on non-empty delayed iputs Date: Thu, 30 Aug 2018 13:42:13 -0400 Message-Id: <20180830174225.2200-24-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180830174225.2200-1-josef@toxicpanda.com> References: <20180830174225.2200-1-josef@toxicpanda.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I ran into an issue where there was some reference being held on an inode that I couldn't track. This assert wasn't triggered, but it at least rules out we're doing something stupid. Signed-off-by: Josef Bacik Reviewed-by: Omar Sandoval --- fs/btrfs/disk-io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 0e42401756b8..11ea2ea7439e 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3979,6 +3979,7 @@ void close_ctree(struct btrfs_fs_info *fs_info) kthread_stop(fs_info->transaction_kthread); kthread_stop(fs_info->cleaner_kthread); + ASSERT(list_empty(&fs_info->delayed_iputs)); set_bit(BTRFS_FS_CLOSING_DONE, &fs_info->flags); btrfs_free_qgroup_config(fs_info);