diff mbox series

[v2,3/3] btrfs: qgroup: Prepare to deprecate some btrfs_qgroup_inherit features

Message ID 20180907102745.10387-4-wqu@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs: qgroup: Prepare to deprecate unused features for btrfs_qgroup_inherit() | expand

Commit Message

Qu Wenruo Sept. 7, 2018, 10:27 a.m. UTC 
Prepare to deprecate the following btrfs_qgroup_inherit features:

1) Flags
   There is only one flag supported, BTRFS_QGROUP_INHERIT_SET_LIMITS,
   however it's never used by btrfs-progs.

2) num_excl|ref_copies
   These two features are going to copy excl/rfer numbers from one
   qgroup to another.
   There is no easier way to screw up qgroup numbers like this.

3) btrfs_qgroup_inherit::lim
   It's used along with BTRFS_QGROUP_INHERIT_SET_LIMITS, never supported
   by btrfs-progs either.

Just output warnings for such features for now.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/btrfs/qgroup.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff mbox series

Patch

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 75e1dccf8ed3..aecd3cfc7c78 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -2248,6 +2248,9 @@  int btrfs_validate_inherit(struct btrfs_fs_info *fs_info,
 
 	if (inherit->flags & ~BTRFS_QGROUP_INHERIT_FLAGS_SUPP)
 		return -ENOTTY;
+	if (inherit->flags & BTRFS_QGROUP_INHERIT_SET_LIMITS)
+		btrfs_warn(fs_info,
+"btrfs_qgroup_inherit::flags BTRFS_QGROUP_INHERIT_SET_LIMITS will be deprecated");
 
 	/* Size check */
 	if (sizeof(u64) * inherit->num_qgroups +
@@ -2256,12 +2259,20 @@  int btrfs_validate_inherit(struct btrfs_fs_info *fs_info,
 	    sizeof(*inherit) >
 	    min_t(u64, BTRFS_QGROUP_INHERIT_MAX_SIZE, inherit_size))
 		return -EINVAL;
+	if (inherit->num_excl_copies || inherit->num_ref_copies)
+		btrfs_warn(fs_info,
+	"btrfs_qgroup_inherit::num_excl/ref_copies will be deprecated");
 
 	/* Qgroup 0/0 is not allowed */
 	for (i = 0; i < inherit->num_qgroups; i++) {
 		if (inherit->qgroups[i] == 0)
 			return -EINVAL;
 	}
+	if (inherit->lim.max_rfer || inherit->lim.max_excl ||
+	    inherit->lim.rsv_rfer || inherit->lim.rsv_excl ||
+	    inherit->lim.flags)
+		btrfs_warn(fs_info,
+			"btrfs_qgroup_inherit::lim will be deprecated");
 	return 0;
 }