| Message ID | 20180914072505.15916-2-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enhanced error messages for btrfs-convert | expand |
On 14.09.2018 10:25, Qu Wenruo wrote: > When pread64() returns value smaller than expected, it normally means > EIO, so just return -EIO to replace the intermediate number. > So when IO fails, we should be able to get more meaningful error number > of than EPERM. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > convert/source-fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/convert/source-fs.c b/convert/source-fs.c > index b6d08370428a..5660a22cc652 100644 > --- a/convert/source-fs.c > +++ b/convert/source-fs.c > @@ -201,7 +201,7 @@ int read_disk_extent(struct btrfs_root *root, u64 bytenr, > ret = 0; > fail: > if (ret > 0) > - ret = -1; > + ret = -EIO; > return ret; > } > >
diff --git a/convert/source-fs.c b/convert/source-fs.c index b6d08370428a..5660a22cc652 100644 --- a/convert/source-fs.c +++ b/convert/source-fs.c @@ -201,7 +201,7 @@ int read_disk_extent(struct btrfs_root *root, u64 bytenr, ret = 0; fail: if (ret > 0) - ret = -1; + ret = -EIO; return ret; }
When pread64() returns value smaller than expected, it normally means EIO, so just return -EIO to replace the intermediate number. So when IO fails, we should be able to get more meaningful error number of than EPERM. Signed-off-by: Qu Wenruo <wqu@suse.com> --- convert/source-fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)