diff mbox series

[24/42] btrfs: assert on non-empty delayed iputs

Message ID	20181011195431.3441-25-josef@toxicpanda.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-btrfs-owner@kernel.org> From: Josef Bacik <josef@toxicpanda.com> To: kernel-team@fb.com, linux-btrfs@vger.kernel.org Subject: [PATCH 24/42] btrfs: assert on non-empty delayed iputs Date: Thu, 11 Oct 2018 15:54:13 -0400 Message-Id: <20181011195431.3441-25-josef@toxicpanda.com> In-Reply-To: <20181011195431.3441-1-josef@toxicpanda.com> References: <20181011195431.3441-1-josef@toxicpanda.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk
Series	My current patch queue \| expand [00/42,v4] My current patch queue [01/42] btrfs: add btrfs_delete_ref_head helper [02/42] btrfs: add cleanup_ref_head_accounting helper [03/42] btrfs: cleanup extent_op handling [04/42] btrfs: only track ref_heads in delayed_ref_updates [05/42] btrfs: only count ref heads run in __btrfs_run_delayed_refs [06/42] btrfs: introduce delayed_refs_rsv [07/42] btrfs: check if free bgs for commit [08/42] btrfs: dump block_rsv whe dumping space info [09/42] btrfs: release metadata before running delayed refs [10/42] btrfs: protect space cache inode alloc with nofs [11/42] btrfs: fix truncate throttling [12/42] btrfs: don't use global rsv for chunk allocation [13/42] btrfs: add ALLOC_CHUNK_FORCE to the flushing code [14/42] btrfs: reset max_extent_size properly [15/42] btrfs: don't enospc all tickets on flush failure [16/42] btrfs: loop in inode_rsv_refill [17/42] btrfs: run delayed iputs before committing [18/42] btrfs: move the dio_sem higher up the callchain [19/42] btrfs: set max_extent_size properly [20/42] btrfs: don't use ctl->free_space for max_extent_size [21/42] btrfs: reset max_extent_size on clear in a bitmap [22/42] btrfs: only run delayed refs if we're committing [23/42] btrfs: make sure we create all new bgs [24/42] btrfs: assert on non-empty delayed iputs [25/42] btrfs: pass delayed_refs_root to btrfs_delayed_ref_lock [26/42] btrfs: make btrfs_destroy_delayed_refs use btrfs_delayed_ref_lock [27/42] btrfs: make btrfs_destroy_delayed_refs use btrfs_delete_ref_head [28/42] btrfs: handle delayed ref head accounting cleanup in abort [29/42] btrfs: call btrfs_create_pending_block_groups unconditionally [30/42] btrfs: just delete pending bgs if we are aborted [31/42] btrfs: cleanup pending bgs on transaction abort [32/42] btrfs: only free reserved extent if we didn't insert it [33/42] btrfs: fix insert_reserved error handling [34/42] btrfs: wait on ordered extents on abort cleanup [35/42] MAINTAINERS: update my email address for btrfs [36/42] btrfs: wait on caching when putting the bg cache [37/42] btrfs: wakeup cleaner thread when adding delayed iput [38/42] btrfs: be more explicit about allowed flush states [39/42] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue [40/42] btrfs: drop min_size from evict_refill_and_join [41/42] btrfs: reserve extra space during evict() [42/42] btrfs: don't run delayed_iputs in commit

Commit Message

Josef Bacik Oct. 11, 2018, 7:54 p.m. UTC

I ran into an issue where there was some reference being held on an
inode that I couldn't track.  This assert wasn't triggered, but it at
least rules out we're doing something stupid.

Reviewed-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/btrfs/disk-io.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 377ad9c1cb17..39bd158466cd 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3979,6 +3979,7 @@  void close_ctree(struct btrfs_fs_info *fs_info)
 	kthread_stop(fs_info->transaction_kthread);
 	kthread_stop(fs_info->cleaner_kthread);
 
+	ASSERT(list_empty(&fs_info->delayed_iputs));
 	set_bit(BTRFS_FS_CLOSING_DONE, &fs_info->flags);
 
 	btrfs_free_qgroup_config(fs_info);