From patchwork Wed Dec 26 05:37:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10742829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C8FA13B5 for ; Wed, 26 Dec 2018 05:38:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3907A288DB for ; Wed, 26 Dec 2018 05:38:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CF3D28941; Wed, 26 Dec 2018 05:38:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2932E28A29 for ; Wed, 26 Dec 2018 05:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbeLZFiQ (ORCPT ); Wed, 26 Dec 2018 00:38:16 -0500 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:41324 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbeLZFiP (ORCPT ); Wed, 26 Dec 2018 00:38:15 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 67453B47 for ; Wed, 26 Dec 2018 05:38:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YY4LshAhjKlh for ; Tue, 25 Dec 2018 23:38:13 -0600 (CST) Received: from mail-it1-f199.google.com (mail-it1-f199.google.com [209.85.166.199]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 3707BB04 for ; Tue, 25 Dec 2018 23:38:13 -0600 (CST) Received: by mail-it1-f199.google.com with SMTP id p21so17759466itb.8 for ; Tue, 25 Dec 2018 21:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=o+ZaauZY/rSwkfY3UC6i1AxUZHMBSL5wYx1f/vwR7b0=; b=F2wY5QHCN4ULFbEj1ZZ/Pl+gL3+Z+pc0TtLmsXwjzvyToeyEREGgN2i1J9ce/UEc1G 449MVrRLcIMVBuaLkz7XkJOb5E/TRg9x6DOEPdF9DcM4sXfuubjxOy1Sa9JvtJaB6CC1 o558ugW1xa7Kgwh7yyR6wMzX85YTwaKfbid2J7/67RxJ1lnkToGqsb6OasMsiTUiNXPP GQkXgnLRa/zlGYOnvKYRUnR6NNtWD5e5Io/IdNCraI324RfpMb04WpkIGyLwbe8pLeVL VODxB+2jEpfm8sVCF1GpzPX3utcl7eWlVXonNsSksII4CvLq61gVTEgH/X0EwErjTeNa ExCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=o+ZaauZY/rSwkfY3UC6i1AxUZHMBSL5wYx1f/vwR7b0=; b=BeebOBndcVOfl5z68GucqkE7uOo3LsWrw5TzeoWxyCfzwlNhGYnQL7PAo8teDDm6ex W0I9WySCykXDJdmMTkuSxealyss0gkCae1doFVZmU1NSUgxJOUwDpiWwW9pUMG44KsgE xmGemmwxg7INFwtBBdwAJDAJgs5GzvTQPV6pYuniTeDoVUQaZ1D3PxS5e+8TkbfSZg7t ko3tteliRKbsuOju35mPHKi21wRKLdLS8G7ED7ZkrBGt/lbd0NB677XMz9E5bpV4o1Q/ OnpZ/hT66HSuPhBKRV/oqxmdHdHvv8SoZTJHon0Gp60KM7GsuTFqyd3VN2jLKUHQHv6B Ws2A== X-Gm-Message-State: AA+aEWZIxHW0CwP4g86yQs/BeJ8QpvSvCcLcWM/SpxAxW/WT2y+muuRx 7iGfoV0gsvOz2NLX5ZfB+WDlHKWDx8bjOJWzE8me2JOPXeOZdZw4EFK8StdN4ZJNO5hSbZrkKWl boAVE6HvT8R4PsEG7onrpJ5KIpE4= X-Received: by 2002:a24:248:: with SMTP id 69mr11780438itu.91.1545802692362; Tue, 25 Dec 2018 21:38:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/WJTajMAXjiO3aG93CSqJjXBREYjR6yT4KMpN/BczApQT7kk+AEodbd4Aaq2vk647dmPv2dWw== X-Received: by 2002:a24:248:: with SMTP id 69mr11780428itu.91.1545802692124; Tue, 25 Dec 2018 21:38:12 -0800 (PST) Received: from localhost.localdomain (host-173-230-104-22.mnmigsc.mn.minneapolis.us.clients.pavlovmedia.net. [173.230.104.22]) by smtp.gmail.com with ESMTPSA id c194sm13767233itc.3.2018.12.25.21.38.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Dec 2018 21:38:11 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] btrfs: add a check for sysfs_create_group Date: Tue, 25 Dec 2018 23:37:44 -0600 Message-Id: <20181226053744.74740-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.2 (Apple Git-113) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case sysfs_create_group fails, let's check its return value and issues an error message. Signed-off-by: Kangjie Lu Reviewed-by: Qu Wenruo --- fs/btrfs/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3717c864ba23..24ef416e700b 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -889,6 +889,8 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, */ sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group); ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); + if (ret) + btrfs_err(fs_info, "failed to create btrfs_feature_attr_group.\n"); } static int btrfs_init_debugfs(void)