| Message ID | 20190117161512.24101-1-dsterba@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: remove unused workqueue helpers | expand |
On 17.01.19 г. 18:15 ч., David Sterba wrote: > The _owner helpers havent' been used since its introduction in > cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are > no external users of the private wq::fs_info pointer. > > Signed-off-by: David Sterba <dsterba@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/async-thread.c | 12 ------------ > fs/btrfs/async-thread.h | 2 -- > 2 files changed, 14 deletions(-) > > diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c > index d522494698fa..44a7942f0457 100644 > --- a/fs/btrfs/async-thread.c > +++ b/fs/btrfs/async-thread.c > @@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg) \ > normal_work_helper(work); \ > } > > -struct btrfs_fs_info * > -btrfs_workqueue_owner(const struct __btrfs_workqueue *wq) > -{ > - return wq->fs_info; > -} > - > -struct btrfs_fs_info * > -btrfs_work_owner(const struct btrfs_work *work) > -{ > - return work->wq->fs_info; > -} > - > bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq) > { > /* > diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h > index 7861c9feba5f..3aceb2e6373a 100644 > --- a/fs/btrfs/async-thread.h > +++ b/fs/btrfs/async-thread.h > @@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq, > void btrfs_destroy_workqueue(struct btrfs_workqueue *wq); > void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max); > void btrfs_set_work_high_priority(struct btrfs_work *work); > -struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work); > -struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq); > bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq); > > #endif >
On Thu, Jan 17, 2019 at 05:15:12PM +0100, David Sterba wrote: > The _owner helpers havent' been used since its introduction in > cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are > no external users of the private wq::fs_info pointer. Tracepoints ... patch dropped.
diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c index d522494698fa..44a7942f0457 100644 --- a/fs/btrfs/async-thread.c +++ b/fs/btrfs/async-thread.c @@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg) \ normal_work_helper(work); \ } -struct btrfs_fs_info * -btrfs_workqueue_owner(const struct __btrfs_workqueue *wq) -{ - return wq->fs_info; -} - -struct btrfs_fs_info * -btrfs_work_owner(const struct btrfs_work *work) -{ - return work->wq->fs_info; -} - bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq) { /* diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h index 7861c9feba5f..3aceb2e6373a 100644 --- a/fs/btrfs/async-thread.h +++ b/fs/btrfs/async-thread.h @@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq, void btrfs_destroy_workqueue(struct btrfs_workqueue *wq); void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max); void btrfs_set_work_high_priority(struct btrfs_work *work); -struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work); -struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq); bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq); #endif
The _owner helpers havent' been used since its introduction in cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are no external users of the private wq::fs_info pointer. Signed-off-by: David Sterba <dsterba@suse.com> --- fs/btrfs/async-thread.c | 12 ------------ fs/btrfs/async-thread.h | 2 -- 2 files changed, 14 deletions(-)