Message ID | 20190402100742.8355-2-anand.jain@oracle.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | btrfs: fix property bugs | expand |
On Tue, Apr 02, 2019 at 06:07:38PM +0800, Anand Jain wrote: > We let to pass zstd compression parameter even if its not fully written. > For example: > btrfs prop set /btrfs compression zst > btrfs prop get /btrfs compression > compression=zst > > zlib and lzo are fine. > > Fix it by using the expected number of char in strncmp(). > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c index f1a8be67f639..3cc007e3c7f8 100644 --- a/fs/btrfs/props.c +++ b/fs/btrfs/props.c @@ -304,7 +304,7 @@ static int prop_compression_apply(struct inode *inode, const char *value, btrfs_set_fs_incompat(fs_info, COMPRESS_LZO); } else if (!strncmp("zlib", value, 4)) { type = BTRFS_COMPRESS_ZLIB; - } else if (!strncmp("zstd", value, len)) { + } else if (!strncmp("zstd", value, 4)) { type = BTRFS_COMPRESS_ZSTD; btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD); } else {