From patchwork Tue Sep 1 14:40:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikolay Borisov X-Patchwork-Id: 11748461 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97921618 for ; Tue, 1 Sep 2020 14:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A4B021582 for ; Tue, 1 Sep 2020 14:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbgIAOlL (ORCPT ); Tue, 1 Sep 2020 10:41:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:56364 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727946AbgIAOkh (ORCPT ); Tue, 1 Sep 2020 10:40:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 87FB2B65B; Tue, 1 Sep 2020 14:40:04 +0000 (UTC) From: Nikolay Borisov To: linux-btrfs@vger.kernel.org Cc: Nikolay Borisov Subject: [PATCH 5/5] btrfs: improve error message in setup_items_for_insert Date: Tue, 1 Sep 2020 17:40:01 +0300 Message-Id: <20200901144001.4265-6-nborisov@suse.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200901144001.4265-1-nborisov@suse.com> References: <20200901144001.4265-1-nborisov@suse.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org While at it also print the leaf content after the error. Signed-off-by: Nikolay Borisov Reviewed-by: Josef Bacik --- fs/btrfs/ctree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index bb89c0954ca1..2c3f78cc6aa2 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -4799,9 +4799,9 @@ void setup_items_for_insert(struct btrfs_root *root, struct btrfs_path *path, unsigned int old_data = btrfs_item_end_nr(leaf, slot); if (old_data < data_end) { - btrfs_print_leaf(leaf); - btrfs_crit(fs_info, "slot %d old_data %d data_end %d", + btrfs_crit(fs_info, "item's (slot %d) data offset (%d) beyond data end of leaf (%d)", slot, old_data, data_end); + btrfs_print_leaf(leaf); BUG(); } /*