| Message ID | 20201112112402.784923-1-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: Remove useless statement in split_node | expand |
On 12/11/2020 12:24, Nikolay Borisov wrote: > At the point when we set 'ret = 0' it's guaranteed that the function is > going to return 0 so directly return 0. No functional changes. Indeed, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On Thu, Nov 12, 2020 at 01:24:02PM +0200, Nikolay Borisov wrote: > At the point when we set 'ret = 0' it's guaranteed that the function is > going to return 0 so directly return 0. No functional changes. > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> Added to misc-next, thanks.
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 6c309dfee3f5..04cff286dcc4 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -3449,7 +3449,6 @@ static noinline int split_node(struct btrfs_trans_handle *trans, (c_nritems - mid) * sizeof(struct btrfs_key_ptr)); btrfs_set_header_nritems(split, c_nritems - mid); btrfs_set_header_nritems(c, mid); - ret = 0; btrfs_mark_buffer_dirty(c); btrfs_mark_buffer_dirty(split); @@ -3467,7 +3466,7 @@ static noinline int split_node(struct btrfs_trans_handle *trans, btrfs_tree_unlock(split); free_extent_buffer(split); } - return ret; + return 0; } /*
At the point when we set 'ret = 0' it's guaranteed that the function is going to return 0 so directly return 0. No functional changes. Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- fs/btrfs/ctree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)