| Message ID | 20210122095805.620458-2-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make btrfs W=1 clean | expand |
On 22/01/2021 11:17, Nikolay Borisov wrote: > Fixes fs/btrfs/extent_map.c:399: warning: Function parameter or member > 'modified' not described in 'add_extent_mapping' > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/extent_map.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c > index bd6229fb2b6f..c540a37cbdb2 100644 > --- a/fs/btrfs/extent_map.c > +++ b/fs/btrfs/extent_map.c > @@ -385,9 +385,12 @@ static void extent_map_device_clear_bits(struct extent_map *em, unsigned bits) > } > > /** > - * add_extent_mapping - add new extent map to the extent tree > + * Add new extent map to the extent tree > + * > * @tree: tree to insert new map in > * @em: map to insert > + * @modified: bool indicating whether the given @em should be added to the > + * modified list, which indicates the extent needs to be logged > * > * Insert @em into @tree or perform a simple forward/backward merge with > * existing mappings. The extent_map struct passed in will be inserted > Looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Although this warrants a follow up patch changing modified from int to bool (and for setup_extent_mapping as well).
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index bd6229fb2b6f..c540a37cbdb2 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c @@ -385,9 +385,12 @@ static void extent_map_device_clear_bits(struct extent_map *em, unsigned bits) } /** - * add_extent_mapping - add new extent map to the extent tree + * Add new extent map to the extent tree + * * @tree: tree to insert new map in * @em: map to insert + * @modified: bool indicating whether the given @em should be added to the + * modified list, which indicates the extent needs to be logged * * Insert @em into @tree or perform a simple forward/backward merge with * existing mappings. The extent_map struct passed in will be inserted
Fixes fs/btrfs/extent_map.c:399: warning: Function parameter or member 'modified' not described in 'add_extent_mapping' Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- fs/btrfs/extent_map.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)