From patchwork Mon Feb 1 21:28:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goffredo Baroncelli X-Patchwork-Id: 12060093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB34FC433E0 for ; Mon, 1 Feb 2021 21:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9034164D9C for ; Mon, 1 Feb 2021 21:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232455AbhBAV3S (ORCPT ); Mon, 1 Feb 2021 16:29:18 -0500 Received: from smtp-36-i2.italiaonline.it ([213.209.12.36]:38048 "EHLO libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232426AbhBAV3Q (ORCPT ); Mon, 1 Feb 2021 16:29:16 -0500 Received: from venice.bhome ([84.220.24.72]) by smtp-36.iol.local with ESMTPA id 6gkIlJHtRi3tS6gkJlGsyl; Mon, 01 Feb 2021 22:28:31 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2014; t=1612214911; bh=UeWsWdVX2hG4DDOhccyOZTViSL1fsnuo93+PsdEZcLE=; h=From; b=JPSzmI81Al9gYO3x+SlIAg0zBdPyUjwMVhOh8V4WWObjYo0JyjkC4KiLcEfLTRBdb H3Fit1aE/CeLXcWbVEISw4FwHrH9nxolMYFOTh3X4w2jBmxSY3whVH9vM/gCIejGdq jm+hnukNiNyH5kMJUvwO/u46POfm5DHiic5YQ82TDVyYpg7Jwh2uim9xAxoFJ9VGbN hupYl2txkQAvUGGdpC+Jax0TEDoxFq4EKEP2r7sjHLEybIiXkD60ufPCtcUSJjbQgy KfI1MfbJTJ/pMQh3w3+mBnV3JkrW7YVzfITmzbPLdzJnbJ+e56e8PtzDKROSCscZro ji4auvJTFRc5A== X-CNFS-Analysis: v=2.4 cv=FqfAQ0nq c=1 sm=1 tr=0 ts=6018727f cx=a_exe a=tAq5w2qrEf5dL+VNPEPBHQ==:117 a=tAq5w2qrEf5dL+VNPEPBHQ==:17 a=H_GH1sqfpLVmWqknqvIA:9 From: Goffredo Baroncelli To: linux-btrfs@vger.kernel.org Cc: Zygo Blaxell , Josef Bacik , Goffredo Baroncelli Subject: [PATCH 2/2] btrfs-progs: new "allocation_hint" property. Date: Mon, 1 Feb 2021 22:28:29 +0100 Message-Id: <20210201212829.64966-3-kreijack@libero.it> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210201212829.64966-1-kreijack@libero.it> References: <20210201212829.64966-1-kreijack@libero.it> MIME-Version: 1.0 X-CMAE-Envelope: MS4xfEY/thlbimuanFa9UWLg67RvGMqW7ZqkPN+9JE4dYzIK0JlItMi6+pI9XgI/CQAZ8+VIwSWwBd1Rd7RQoEJQKdE5o531/dvQZdNZyhAGgT3zu4LViCl+ K8oV4LKXKT9nQ59heZKDGwrjTY540o5LJhKEYQYXjjDBcXCueOwuxyBfDSATbVNQ4M3KqEo1dfAvRkhN0Y4kfPRFOZfk3V7nYjbEV8X20Q//LBEdpDJNsYaS anrDCh/eY2s7DS3USj60LYEzV2MGSAgrfA07dWDS+3sRdSPjY5dcFEqE1H0vuxW4 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Goffredo Baroncelli Handle the property allocation_hint of a btrfs device. Below an example of use: $ # set a new value $ sudo btrfs property set /dev/vde allocation_hint DATA_ONLY $ # get the current value $ sudo btrfs property get /dev/vde allocation_hint devid=4, path=/dev/vde: dedicated_metadata=DATA_ONLY The following properties are availables: - DATA_ONLY - PREFERRED_DATA (default) - PREFERRED_METADATA - METADATA_ONLY Root privileges are required. Signed-off-by: Goffredo Baroncelli --- kernel-shared/ctree.h | 15 ++++ props.c | 170 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 185 insertions(+) diff --git a/kernel-shared/ctree.h b/kernel-shared/ctree.h index 7683b8bb..844df9ce 100644 --- a/kernel-shared/ctree.h +++ b/kernel-shared/ctree.h @@ -219,6 +219,21 @@ struct btrfs_mapping_tree { struct cache_tree cache_tree; }; +/* btrfs chunk allocation hints */ +#define BTRFS_DEV_ALLOCATION_MASK_BIT_COUNT 3 +#define BTRFS_DEV_ALLOCATION_MASK ((1ULL << \ + BTRFS_DEV_ALLOCATION_MASK_BIT_COUNT) -1) +/* preferred metadata chunk, but data chunk allowed */ +#define BTRFS_DEV_ALLOCATION_PREFERRED_METADATA (1ULL) +/* only metadata chunk are allowed */ +#define BTRFS_DEV_ALLOCATION_METADATA_ONLY (2ULL) +/* only data chunk allowed */ +#define BTRFS_DEV_ALLOCATION_DATA_ONLY (3ULL) +/* preferred data chunk, but metadata chunk allowed */ +#define BTRFS_DEV_ALLOCATION_PREFERRED_DATA (0ULL) +/* 5..7 are unused values */ + + #define BTRFS_UUID_SIZE 16 struct btrfs_dev_item { /* the internal btrfs device id */ diff --git a/props.c b/props.c index 0cfc358d..2f5f6482 100644 --- a/props.c +++ b/props.c @@ -20,6 +20,7 @@ #include #include #include +#include #include @@ -166,6 +167,169 @@ out: return ret; } +static int btrfs_find_devid_and_mnt(const char *devpath, int *devid, + char *path, int maxpath) +{ + int ret, i, fd; + DIR *dir; + struct stat stdevpath; + struct btrfs_ioctl_fs_info_args fi_args; + struct btrfs_ioctl_dev_info_args dev_info; + + ret = get_btrfs_mount(devpath, path, maxpath); + if (ret) + return ret; + + fd = btrfs_open_dir(path, &dir, 1); + if (fd < 0) + return fd; + + ret = stat(devpath, &stdevpath); + if (ret) { + error("cannot stat '%s'", devpath); + goto out; + } + + ret = ioctl(fd, BTRFS_IOC_FS_INFO, &fi_args); + if (ret < 0) { + if (errno == EPERM) + return -errno; + error("cannot get filesystem info: %m"); + ret = -10; + goto out; + } + + for (i = 0 ; i <= fi_args.max_id ; i++) { + struct stat st; + memset(&dev_info, 0, sizeof(dev_info)); + ret = get_device_info(fd, i, &dev_info); + if (ret == -ENODEV) + continue; + if (ret) { + error("cannot get info about device devid=%d", i); + goto out; + } + + if (!dev_info.path) + /* missing devices */ + continue; + + ret = stat((char*)dev_info.path, &st); + if (ret) { + error("cannot stat '%s'", devpath); + goto out; + } + + if (major(st.st_rdev) == major(stdevpath.st_rdev) && + minor(st.st_rdev) == minor(stdevpath.st_rdev)) { + *devid = dev_info.devid; + ret = 0; + goto out; + } + } + + ret = -12; + +out: + close_file_or_dir(fd, dir); + return ret; +} + +static struct ull_charp_pair_t { + u64 value; + const char *descr; +} allocation_hint_description[] = { + {BTRFS_DEV_ALLOCATION_PREFERRED_METADATA, "PREFERRED_METADATA"}, + {BTRFS_DEV_ALLOCATION_METADATA_ONLY, "METADATA_ONLY"}, + {BTRFS_DEV_ALLOCATION_PREFERRED_DATA, "PREFERRED_DATA"}, + {BTRFS_DEV_ALLOCATION_DATA_ONLY, "DATA_ONLY"}, + {0, NULL} +}; + + +static int prop_allocation_hint(enum prop_object_type type, + const char *object, + const char *name, + const char *value) +{ + int ret, devid, fd; + char path[PATH_MAX]; + DIR *dir; + struct btrfs_ioctl_dev_properties props; + int i; + u64 v; + + ret = btrfs_find_devid_and_mnt(object, &devid, path, sizeof(path)); + if (ret) + return -5; + + fd = btrfs_open_dir(path, &dir, 1); + if (fd < 0) + return fd; + + memset(&props, 0, sizeof(props)); + props.devid = devid; + props.properties = BTRFS_DEV_PROPERTY_TYPE|BTRFS_DEV_PROPERTY_READ; + ret = ioctl(fd, BTRFS_IOC_DEV_PROPERTIES, &props); + if (ret < 0) { + error("Cannot perform BTRFS_IOC_DEV_PROPERTIES ioctl on '%s'", + path); + ret = -1; + goto out; + } + + if (!value) { + v = props.type & BTRFS_DEV_ALLOCATION_MASK; + for (i = 0 ; allocation_hint_description[i].descr ; i++) + if (v == allocation_hint_description[i].value) + break; + if (allocation_hint_description[i].descr) + printf("devid=%d, path=%s: allocation_hint=%s\n", + devid, object, + allocation_hint_description[i].descr); + else + printf("devid=%d, path=%s: allocation_hint=unknow:%llu\n", + devid, object, + v); + ret = 0; + goto out; + } + + for (i = 0 ; allocation_hint_description[i].descr ; i++) + if (!strcmp(value, allocation_hint_description[i].descr)) + break; + + if (allocation_hint_description[i].descr) { + v = allocation_hint_description[i].value; + } else if (sscanf(value, "%llu", &v) != 1) { + error("Invalid value '%s'\n", value); + ret = -3; + goto out; + } else if (v & ~BTRFS_DEV_ALLOCATION_MASK) { + error("Invalid value '%s'\n", value); + ret = -3; + goto out; + } + + props.type &= ~BTRFS_DEV_ALLOCATION_MASK; + props.type |= (v & BTRFS_DEV_ALLOCATION_MASK); + + props.properties = BTRFS_DEV_PROPERTY_TYPE; + props.devid = devid; + ret = ioctl(fd, BTRFS_IOC_DEV_PROPERTIES, &props); + if (ret < 0) { + error("Cannot perform BTRFS_IOC_DEV_PROPERTIES ioctl on '%s'", + path); + ret = -4; + goto out; + } + + ret = 0; +out: + close_file_or_dir(fd, dir); + return ret; +} + const struct prop_handler prop_handlers[] = { { .name ="ro", @@ -187,5 +351,11 @@ const struct prop_handler prop_handlers[] = { .read_only = 0, .types = prop_object_inode, prop_compression }, + { + .name = "allocation_hint", + .desc = "hint to store teh data/metadata chunks", + .types = prop_object_dev, + .handler = prop_allocation_hint + }, {NULL, NULL, 0, 0, NULL} };