diff mbox series

btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits

Message ID 20210211081405.392006-1-wqu@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs: ordered-extent: fix comment for btrfs ordered extent flag bits | expand

Commit Message

Qu Wenruo Feb. 11, 2021, 8:14 a.m. UTC
There is small error in comment about BTRFS_ORDERED_* flags.

The 4 types are for ordered extent itself, not for direct io.
Only 3 types support direct io, REGULAR/NOCOW/PREALLOC.

Fix the comment to reflect that.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 fs/btrfs/ordered-data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Sterba Feb. 16, 2021, 2:34 p.m. UTC | #1
On Thu, Feb 11, 2021 at 04:14:05PM +0800, Qu Wenruo wrote:
> There is small error in comment about BTRFS_ORDERED_* flags.
> 
> The 4 types are for ordered extent itself, not for direct io.
> Only 3 types support direct io, REGULAR/NOCOW/PREALLOC.
> 
> Fix the comment to reflect that.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Added to misc-next, thanks.
diff mbox series

Patch

diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
index 99e0853e4d3b..e60c07f36427 100644
--- a/fs/btrfs/ordered-data.h
+++ b/fs/btrfs/ordered-data.h
@@ -39,8 +39,8 @@  struct btrfs_ordered_sum {
  */
 enum {
 	/*
-	 * Different types for direct io, one and only one of the 4 type can
-	 * be set when creating ordered extent.
+	 * Different types for ordered extents, one and only one of the 4 types
+	 * need to be set when creating ordered extent.
 	 *
 	 * REGULAR:	For regular non-compressed COW write
 	 * NOCOW:	For NOCOW write into existing non-hole extent