| Message ID | 20210611013114.57264-2-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: compression: refactor and enhancement preparing for subpage compression support | expand |
On 11/6/21 9:31 am, Qu Wenruo wrote: > Since commit 8140dc30a432 ("btrfs: btrfs_decompress_bio() could accept > compressed_bio instead"), btrfs_decompress_bio() accepts > "struct compressed_bio" other than open-coded parameter list. > > Thus the comments for the parameter list is no longer needed. > > Signed-off-by: Qu Wenruo <wqu@suse.com> Oh. Reviewed-by: Anand Jain <anand.jain@oracle.com> > --- > fs/btrfs/compression.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c > index 831e6ae92940..fc4f37adb7b7 100644 > --- a/fs/btrfs/compression.c > +++ b/fs/btrfs/compression.c > @@ -1208,20 +1208,6 @@ int btrfs_compress_pages(unsigned int type_level, struct address_space *mapping, > return ret; > } > > -/* > - * pages_in is an array of pages with compressed data. > - * > - * disk_start is the starting logical offset of this array in the file > - * > - * orig_bio contains the pages from the file that we want to decompress into > - * > - * srclen is the number of bytes in pages_in > - * > - * The basic idea is that we have a bio that was created by readpages. > - * The pages in the bio are for the uncompressed data, and they may not > - * be contiguous. They all correspond to the range of bytes covered by > - * the compressed extent. > - */ > static int btrfs_decompress_bio(struct compressed_bio *cb) > { > struct list_head *workspace; >
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 831e6ae92940..fc4f37adb7b7 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c @@ -1208,20 +1208,6 @@ int btrfs_compress_pages(unsigned int type_level, struct address_space *mapping, return ret; } -/* - * pages_in is an array of pages with compressed data. - * - * disk_start is the starting logical offset of this array in the file - * - * orig_bio contains the pages from the file that we want to decompress into - * - * srclen is the number of bytes in pages_in - * - * The basic idea is that we have a bio that was created by readpages. - * The pages in the bio are for the uncompressed data, and they may not - * be contiguous. They all correspond to the range of bytes covered by - * the compressed extent. - */ static int btrfs_decompress_bio(struct compressed_bio *cb) { struct list_head *workspace;
Since commit 8140dc30a432 ("btrfs: btrfs_decompress_bio() could accept compressed_bio instead"), btrfs_decompress_bio() accepts "struct compressed_bio" other than open-coded parameter list. Thus the comments for the parameter list is no longer needed. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/btrfs/compression.c | 14 -------------- 1 file changed, 14 deletions(-)