[2/3] btrfs-progs: tests: don't check subpage related warnings for fsck type 1 tests

Commit Message

Qu Wenruo Aug. 18, 2021, 6:44 a.m. UTC

For fsck tests, we check the subpage warnings for each type 1 test, but
such type 1 tests are mostly read-only tests, and one of the test will
trigger new subpage related warnings (fsck/018).

For subpage related warnings, what we really care are write operations,
including mkfs, btrfs-convert and repair, not those read-only tests.

So skip the subpage warning check for fsck type 1 tests to prevent false
alert of later more strict subpage warnings.

Signed-off-by: Qu Wenruo <[e-mail]>
---
 tests/fsck-tests.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Patch

diff --git a/tests/fsck-tests.sh b/tests/fsck-tests.sh
index ed18136f3ab9..70b307ab9629 100755
--- a/tests/fsck-tests.sh
+++ b/tests/fsck-tests.sh
@@ -64,7 +64,14 @@  run_one_test() {
 			fi
 			_fail "test failed for case $(basename $testname)"
 		fi
-		check_test_results "$RESULTS" "$testname"
+		# These tests have overriden check_image() and their
+		# images may have intentional unaligned metadata to trigger
+		# subpage warnings (like fsck/018), skip the check for their
+		# subpage warnings.
+		#
+		# We care subpage related warnings for write operations
+		# (mkfs/convert/repair), not those read-only checks on
+		# pre-crafted images.
 	else
 		# Type 1
 		check_all_images