| Message ID | 20220427160255.300418-7-p.raghav@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/16] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze | expand |
On Wed, Apr 27, 2022 at 06:02:45PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > Instead of open coding the number of zones given a sector, use the helper > blk_queue_zone_no(). This let's us make modifications to the math if > needed in one place and adds now support for npo2 zone devices. > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> > --- > drivers/nvme/target/zns.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c > index e34718b09550..e41b6a6ef048 100644 > --- a/drivers/nvme/target/zns.c > +++ b/drivers/nvme/target/zns.c > @@ -243,7 +243,7 @@ static unsigned long nvmet_req_nr_zones_from_slba(struct nvmet_req *req) > unsigned int sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba); > > return blkdev_nr_zones(req->ns->bdev->bd_disk) - > - (sect >> ilog2(bdev_zone_sectors(req->ns->bdev))); > + bdev_zone_no(req->ns->bdev, sect); > } > > static unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 bufsize) > -- > 2.25.1 > Looks good. Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
On 4/27/22 09:02, Pankaj Raghav wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > Instead of open coding the number of zones given a sector, use the helper ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I can't parse this. Please rephrase this. > blk_queue_zone_no(). This let's us make modifications to the math if > needed in one place and adds now support for npo2 zone devices. But since the code looks fine: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 4/27/22 09:02, Pankaj Raghav wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > Instead of open coding the number of zones given a sector, use the helper > blk_queue_zone_no(). This let's us make modifications to the math if > needed in one place and adds now support for npo2 zone devices. > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> > --- > drivers/nvme/target/zns.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c index e34718b09550..e41b6a6ef048 100644 --- a/drivers/nvme/target/zns.c +++ b/drivers/nvme/target/zns.c @@ -243,7 +243,7 @@ static unsigned long nvmet_req_nr_zones_from_slba(struct nvmet_req *req) unsigned int sect = nvmet_lba_to_sect(req->ns, req->cmd->zmr.slba); return blkdev_nr_zones(req->ns->bdev->bd_disk) - - (sect >> ilog2(bdev_zone_sectors(req->ns->bdev))); + bdev_zone_no(req->ns->bdev, sect); } static unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 bufsize)