| Message ID | 20220608012158.109334-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] btrfs: Remove the unused function scrub_calc_parity_bitmap_len() | expand |
On Wed, Jun 08, 2022 at 09:21:58AM +0800, Yang Li wrote: > bitmap_len = scrub_calc_parity_bitmap_len(), the only call point of this > function has been deleted, so it should also be removed. > > Fix the following W=1 kernel warning: > fs/btrfs/scrub.c:2857:19: warning: unused function 'scrub_calc_parity_bitmap_len' > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Thanks, fix folded to the patch as it's still in the development branch.
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 46cac7c7f292..db700e6ec5a9 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -2854,11 +2854,6 @@ static void scrub_parity_check_and_repair(struct scrub_parity *sparity) scrub_free_parity(sparity); } -static inline int scrub_calc_parity_bitmap_len(int nsectors) -{ - return DIV_ROUND_UP(nsectors, BITS_PER_LONG) * sizeof(long); -} - static void scrub_parity_get(struct scrub_parity *sparity) { refcount_inc(&sparity->refs);
bitmap_len = scrub_calc_parity_bitmap_len(), the only call point of this function has been deleted, so it should also be removed. Fix the following W=1 kernel warning: fs/btrfs/scrub.c:2857:19: warning: unused function 'scrub_calc_parity_bitmap_len' Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- fs/btrfs/scrub.c | 5 ----- 1 file changed, 5 deletions(-)