diff mbox series

fstests: add btrfs tests exercising raid to the raid group

Message ID 20221017085317.96172-1-johannes.thumshirn@wdc.com (mailing list archive)
State New, archived
Headers show
Series fstests: add btrfs tests exercising raid to the raid group | expand

Commit Message

Johannes Thumshirn Oct. 17, 2022, 8:53 a.m. UTC 
Several tests for btrfs exercise the raid code, but are not added to the
raid group. Most of these tests pull in raid via
'_btrfs_get_profile_configs()'.

Other tests have a '_require_btrfs_fs_feature raid56' which also pulls in
raid, but are not added to the raid group.

Reported-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 tests/btrfs/027 | 2 +-
 tests/btrfs/060 | 2 +-
 tests/btrfs/061 | 2 +-
 tests/btrfs/062 | 2 +-
 tests/btrfs/063 | 2 +-
 tests/btrfs/064 | 2 +-
 tests/btrfs/065 | 2 +-
 tests/btrfs/066 | 2 +-
 tests/btrfs/067 | 2 +-
 tests/btrfs/068 | 2 +-
 tests/btrfs/069 | 2 +-
 tests/btrfs/070 | 2 +-
 tests/btrfs/071 | 2 +-
 tests/btrfs/072 | 2 +-
 tests/btrfs/073 | 2 +-
 tests/btrfs/074 | 2 +-
 tests/btrfs/125 | 2 +-
 tests/btrfs/148 | 2 +-
 18 files changed, 18 insertions(+), 18 deletions(-)

Comments

Luis Chamberlain Oct. 18, 2022, 6:26 p.m. UTC | #1 
On Mon, Oct 17, 2022 at 01:53:17AM -0700, Johannes Thumshirn wrote:
> Several tests for btrfs exercise the raid code, but are not added to the
> raid group. Most of these tests pull in raid via
> '_btrfs_get_profile_configs()'.
> 
> Other tests have a '_require_btrfs_fs_feature raid56' which also pulls in
> raid, but are not added to the raid group.
> 
> Reported-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Shouldn't we have a raid56 group alone too? Then distros that simply
don't support it can skip those tests.
 
  Luis
Johannes Thumshirn Oct. 19, 2022, 8:34 a.m. UTC | #2 
On 18.10.22 20:26, Luis Chamberlain wrote:
> On Mon, Oct 17, 2022 at 01:53:17AM -0700, Johannes Thumshirn wrote:
>> Several tests for btrfs exercise the raid code, but are not added to the
>> raid group. Most of these tests pull in raid via
>> '_btrfs_get_profile_configs()'.
>>
>> Other tests have a '_require_btrfs_fs_feature raid56' which also pulls in
>> raid, but are not added to the raid group.
>>
>> Reported-by: Luis Chamberlain <mcgrof@kernel.org>
>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> Shouldn't we have a raid56 group alone too? Then distros that simply
> don't support it can skip those tests.
>  
>   Luis
> 

If it's just for skipping RAID56 alone, I think adjusting the 
${BTRFS_PROFILE_CONFIGS[@]} environment variable is a better choice.
diff mbox series

Patch

diff --git a/tests/btrfs/027 b/tests/btrfs/027
index 46c14b9c1c1f..b6d049dec3b3 100755
--- a/tests/btrfs/027
+++ b/tests/btrfs/027
@@ -7,7 +7,7 @@ 
 # Test replace of a missing device on various data and metadata profiles.
 #
 . ./common/preamble
-_begin_fstest auto replace volume
+_begin_fstest auto replace volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/060 b/tests/btrfs/060
index 26db8a9bee20..cdf41074096a 100755
--- a/tests/btrfs/060
+++ b/tests/btrfs/060
@@ -8,7 +8,7 @@ 
 # with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto balance subvol
+_begin_fstest auto balance subvol raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/061 b/tests/btrfs/061
index 55f5625b5490..0a3b2d766f9c 100755
--- a/tests/btrfs/061
+++ b/tests/btrfs/061
@@ -8,7 +8,7 @@ 
 # running in background.
 #
 . ./common/preamble
-_begin_fstest auto balance scrub
+_begin_fstest auto balance scrub raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/062 b/tests/btrfs/062
index 47b0b9373f33..467177a1ffe8 100755
--- a/tests/btrfs/062
+++ b/tests/btrfs/062
@@ -8,7 +8,7 @@ 
 # running in background.
 #
 . ./common/preamble
-_begin_fstest auto balance defrag compress
+_begin_fstest auto balance defrag compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/063 b/tests/btrfs/063
index c96390b9315c..0a023ded65da 100755
--- a/tests/btrfs/063
+++ b/tests/btrfs/063
@@ -8,7 +8,7 @@ 
 # simultaneously, with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto balance remount compress
+_begin_fstest auto balance remount compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/064 b/tests/btrfs/064
index 741161889150..e34713c7ee00 100755
--- a/tests/btrfs/064
+++ b/tests/btrfs/064
@@ -10,7 +10,7 @@ 
 # run simultaneously. One of them is expected to fail when the other is running.
 
 . ./common/preamble
-_begin_fstest auto balance replace volume
+_begin_fstest auto balance replace volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/065 b/tests/btrfs/065
index 4ebf93267a59..ab5febef8410 100755
--- a/tests/btrfs/065
+++ b/tests/btrfs/065
@@ -8,7 +8,7 @@ 
 # operation simultaneously, with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto subvol replace volume
+_begin_fstest auto subvol replace volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/066 b/tests/btrfs/066
index 8d12af616d89..9f3899385400 100755
--- a/tests/btrfs/066
+++ b/tests/btrfs/066
@@ -8,7 +8,7 @@ 
 # operation simultaneously, with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto subvol scrub
+_begin_fstest auto subvol scrub raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/067 b/tests/btrfs/067
index 44803f9faf7f..de056969dd8a 100755
--- a/tests/btrfs/067
+++ b/tests/btrfs/067
@@ -8,7 +8,7 @@ 
 # operation simultaneously, with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto subvol defrag compress
+_begin_fstest auto subvol defrag compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/068 b/tests/btrfs/068
index e03a4891ec89..cd10a87d2f26 100755
--- a/tests/btrfs/068
+++ b/tests/btrfs/068
@@ -9,7 +9,7 @@ 
 # in background.
 #
 . ./common/preamble
-_begin_fstest auto subvol remount compress
+_begin_fstest auto subvol remount compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/069 b/tests/btrfs/069
index 6e798a2e5061..5f5b098452af 100755
--- a/tests/btrfs/069
+++ b/tests/btrfs/069
@@ -8,7 +8,7 @@ 
 # running in background.
 #
 . ./common/preamble
-_begin_fstest auto replace scrub volume
+_begin_fstest auto replace scrub volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/070 b/tests/btrfs/070
index dcf978b36b0c..9f2f8d55d265 100755
--- a/tests/btrfs/070
+++ b/tests/btrfs/070
@@ -8,7 +8,7 @@ 
 # running in background.
 #
 . ./common/preamble
-_begin_fstest auto replace defrag compress volume
+_begin_fstest auto replace defrag compress volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/071 b/tests/btrfs/071
index cd1de2642a96..e65871902b46 100755
--- a/tests/btrfs/071
+++ b/tests/btrfs/071
@@ -8,7 +8,7 @@ 
 # algorithms simultaneously with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto replace remount compress volume
+_begin_fstest auto replace remount compress volume raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/072 b/tests/btrfs/072
index bcb0ea2546a6..423b087f9821 100755
--- a/tests/btrfs/072
+++ b/tests/btrfs/072
@@ -8,7 +8,7 @@ 
 # running in background.
 #
 . ./common/preamble
-_begin_fstest auto scrub defrag compress
+_begin_fstest auto scrub defrag compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/073 b/tests/btrfs/073
index 26c5deb6c2a2..27b67198451e 100755
--- a/tests/btrfs/073
+++ b/tests/btrfs/073
@@ -8,7 +8,7 @@ 
 # simultaneously with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto scrub remount compress
+_begin_fstest auto scrub remount compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/074 b/tests/btrfs/074
index dc26d8c02497..3f254ab7d310 100755
--- a/tests/btrfs/074
+++ b/tests/btrfs/074
@@ -8,7 +8,7 @@ 
 # simultaneously with fsstress running in background.
 #
 . ./common/preamble
-_begin_fstest auto defrag remount compress
+_begin_fstest auto defrag remount compress raid
 
 # Import common functions.
 . ./common/filter
diff --git a/tests/btrfs/125 b/tests/btrfs/125
index b58f2aa282bd..51526f745c84 100755
--- a/tests/btrfs/125
+++ b/tests/btrfs/125
@@ -22,7 +22,7 @@ 
 # Verify if all three checkpoints match
 #
 . ./common/preamble
-_begin_fstest replace volume balance
+_begin_fstest replace volume balance raid
 
 # Override the default cleanup function.
 _cleanup()
diff --git a/tests/btrfs/148 b/tests/btrfs/148
index 510e46dc0826..7bd122e0b08f 100755
--- a/tests/btrfs/148
+++ b/tests/btrfs/148
@@ -7,7 +7,7 @@ 
 # Test that direct IO writes work on RAID5 and RAID6 filesystems.
 #
 . ./common/preamble
-_begin_fstest auto quick rw
+_begin_fstest auto quick rw raid
 
 # Import common functions.
 . ./common/filter