| Message ID | 20221231150501.123205-1-007047221b@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: Fix ASSERT of em->len when getting extent | expand |
On Sat, Dec 31, 2022 at 04:05:01PM +0100, Tanmay Bhushan wrote: > em->len is incorrectly asserted which is leading to it's > assignment to sectorsize instead of being check for it. > > Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> Added to misc-next, thanks.
On 12/31/22 23:05, Tanmay Bhushan wrote: > em->len is incorrectly asserted which is leading to it's > assignment to sectorsize instead of being check for it. > > Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> > --- > fs/btrfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index 8bcad9940154..e49358048a98 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -7092,7 +7092,7 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode, > * Other members are not utilized for inline extents. > */ > ASSERT(em->block_start == EXTENT_MAP_INLINE); > - ASSERT(em->len = fs_info->sectorsize); > + ASSERT(em->len == fs_info->sectorsize); Good catch. Reviewed-by: Anand Jain <anand.jain@oracle.com> > > ret = read_inline_extent(inode, path, page); > if (ret < 0)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 8bcad9940154..e49358048a98 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -7092,7 +7092,7 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode, * Other members are not utilized for inline extents. */ ASSERT(em->block_start == EXTENT_MAP_INLINE); - ASSERT(em->len = fs_info->sectorsize); + ASSERT(em->len == fs_info->sectorsize); ret = read_inline_extent(inode, path, page); if (ret < 0)
em->len is incorrectly asserted which is leading to it's assignment to sectorsize instead of being check for it. Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)