diff mbox series

[6/7] generic: add 251 to the auto group

Message ID 20230209051355.358942-7-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [1/7] btrfs: add 198 and 219 to the auto group | expand

Commit Message

Christoph Hellwig Feb. 9, 2023, 5:13 a.m. UTC
generic/251 isn't dangerous, doesn't takes overly long to run and doesn't
produce spurious failures, so add it to the auto group.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/251 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Feb. 9, 2023, 4:13 p.m. UTC | #1
On Thu, Feb 09, 2023 at 06:13:54AM +0100, Christoph Hellwig wrote:
> generic/251 isn't dangerous, doesn't takes overly long to run and doesn't
> produce spurious failures, so add it to the auto group.

How long does it take for you?  It generally takes 300-700s to run on my
testing cloud.  That's not a reason to keep it out of the auto group,
but I've been surveying the long running tests to find the ones that run
stuff in a loop and subject them to TIME_FACTOR (or the new
SOAK_DURATION knob that I'm working on to allow direct control of loop
runtime) constraints.

--D

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/251 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/251 b/tests/generic/251
> index 192ab5cc..2a271cd1 100755
> --- a/tests/generic/251
> +++ b/tests/generic/251
> @@ -10,7 +10,7 @@
>  # corrupts the filesystem (data/metadata).
>  #
>  . ./common/preamble
> -_begin_fstest ioctl trim
> +_begin_fstest ioctl trim auto
>  
>  tmp=`mktemp -d`
>  trap "_cleanup; exit \$status" 0 1 3
> -- 
> 2.39.1
>
Christoph Hellwig Feb. 9, 2023, 5:11 p.m. UTC | #2
On Thu, Feb 09, 2023 at 08:13:11AM -0800, Darrick J. Wong wrote:
> On Thu, Feb 09, 2023 at 06:13:54AM +0100, Christoph Hellwig wrote:
> > generic/251 isn't dangerous, doesn't takes overly long to run and doesn't
> > produce spurious failures, so add it to the auto group.
> 
> How long does it take for you?

Between 300 and 400 seconds usually.
diff mbox series

Patch

diff --git a/tests/generic/251 b/tests/generic/251
index 192ab5cc..2a271cd1 100755
--- a/tests/generic/251
+++ b/tests/generic/251
@@ -10,7 +10,7 @@ 
 # corrupts the filesystem (data/metadata).
 #
 . ./common/preamble
-_begin_fstest ioctl trim
+_begin_fstest ioctl trim auto
 
 tmp=`mktemp -d`
 trap "_cleanup; exit \$status" 0 1 3