| Message ID | 20230301134244.1378533-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/10] btrfs: remove unused members from struct btrfs_encoded_read_private | expand |
On 01.03.23 14:42, Christoph Hellwig wrote: > The inode and file_offset members in truct btrfs_encoded_read_private struct ~^ Otherwise Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 2023/3/1 21:42, Christoph Hellwig wrote: > The inode and file_offset members in truct btrfs_encoded_read_private > are unused, so remove them. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/inode.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index ecd0aa83927949..9ad0d181c7082a 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -9926,8 +9926,6 @@ static ssize_t btrfs_encoded_read_inline( > } > > struct btrfs_encoded_read_private { > - struct btrfs_inode *inode; > - u64 file_offset; > wait_queue_head_t wait; > atomic_t pending; > blk_status_t status; > @@ -9958,8 +9956,6 @@ int btrfs_encoded_read_regular_fill_pages(struct btrfs_inode *inode, > u64 disk_io_size, struct page **pages) > { > struct btrfs_encoded_read_private priv = { > - .inode = inode, > - .file_offset = file_offset, > .pending = ATOMIC_INIT(1), > }; > unsigned long i = 0;
On 01/03/2023 21:42, Christoph Hellwig wrote: > The inode and file_offset members in truct btrfs_encoded_read_private > are unused, so remove them. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks like commits 7959bd441176 and 7609afac6775 and removed their use. Reviewed-by: Anand Jain <anand.jain@oracle.com>
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index ecd0aa83927949..9ad0d181c7082a 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -9926,8 +9926,6 @@ static ssize_t btrfs_encoded_read_inline( } struct btrfs_encoded_read_private { - struct btrfs_inode *inode; - u64 file_offset; wait_queue_head_t wait; atomic_t pending; blk_status_t status; @@ -9958,8 +9956,6 @@ int btrfs_encoded_read_regular_fill_pages(struct btrfs_inode *inode, u64 disk_io_size, struct page **pages) { struct btrfs_encoded_read_private priv = { - .inode = inode, - .file_offset = file_offset, .pending = ATOMIC_INIT(1), }; unsigned long i = 0;
The inode and file_offset members in truct btrfs_encoded_read_private are unused, so remove them. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/btrfs/inode.c | 4 ---- 1 file changed, 4 deletions(-)