diff mbox series

btrfs: make btrfs_compressed_bioset static

Message ID 20230616172443.87681-1-ben.dooks@codethink.co.uk (mailing list archive)
State New, archived
Headers show
Series btrfs: make btrfs_compressed_bioset static | expand

Commit Message

Ben Dooks June 16, 2023, 5:24 p.m. UTC
The 'btrfs_compressed_bioset' struct isn't exported outside of the
fs/btrfs/compression.c file, so make it static to fix the following
sparse warning:

fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 fs/btrfs/compression.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig June 19, 2023, 5 a.m. UTC | #1
On Fri, Jun 16, 2023 at 06:24:43PM +0100, Ben Dooks wrote:
> The 'btrfs_compressed_bioset' struct isn't exported outside of the
> fs/btrfs/compression.c file, so make it static to fix the following
> sparse warning:
> 
> fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
> 

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
David Sterba June 19, 2023, 3:02 p.m. UTC | #2
On Fri, Jun 16, 2023 at 06:24:43PM +0100, Ben Dooks wrote:
> The 'btrfs_compressed_bioset' struct isn't exported outside of the
> fs/btrfs/compression.c file, so make it static to fix the following
> sparse warning:
> 
> fs/btrfs/compression.c:40:16: warning: symbol 'btrfs_compressed_bioset' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Added to misc-next, thanks.
diff mbox series

Patch

diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 2d0493f0a184..10d8b76313dc 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -37,7 +37,7 @@ 
 #include "file-item.h"
 #include "super.h"
 
-struct bio_set btrfs_compressed_bioset;
+static struct bio_set btrfs_compressed_bioset;
 
 static const char* const btrfs_compress_types[] = { "", "zlib", "lzo", "zstd" };