| Message ID | 20230824064820.72147-1-wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: btrfs/213: fix the _not_run spell | expand |
On Thu, Aug 24, 2023 at 02:48:20PM +0800, Qu Wenruo wrote: > The proper function is _notrun, not _not_run. > > This can cause false alerts if the write speed is too fast or has some > cache causing the balance to finish eariler than expectation. https://lore.kernel.org/fstests/71413edbeb1ee5b945f0b82faccaf4a75e8ba56b.1691924176.git.fdmanana@suse.com/ > > Signed-off-by: Qu Wenruo <wqu@suse.com> > --- > tests/btrfs/213 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/btrfs/213 b/tests/btrfs/213 > index 5666d9b9..6def4f6e 100755 > --- a/tests/btrfs/213 > +++ b/tests/btrfs/213 > @@ -55,7 +55,7 @@ sleep $(($runtime / 4)) > # any error about no balance currently running. > $BTRFS_UTIL_PROG balance cancel "$SCRATCH_MNT" 2>&1 | grep -iq 'not in progress' > if [ $? -eq 0 ]; then > - _not_run "balance finished before we could cancel it" > + _notrun "balance finished before we could cancel it" > fi > > # Now check if we can finish relocating metadata, which should finish very > -- > 2.41.0 >
diff --git a/tests/btrfs/213 b/tests/btrfs/213 index 5666d9b9..6def4f6e 100755 --- a/tests/btrfs/213 +++ b/tests/btrfs/213 @@ -55,7 +55,7 @@ sleep $(($runtime / 4)) # any error about no balance currently running. $BTRFS_UTIL_PROG balance cancel "$SCRATCH_MNT" 2>&1 | grep -iq 'not in progress' if [ $? -eq 0 ]; then - _not_run "balance finished before we could cancel it" + _notrun "balance finished before we could cancel it" fi # Now check if we can finish relocating metadata, which should finish very
The proper function is _notrun, not _not_run. This can cause false alerts if the write speed is too fast or has some cache causing the balance to finish eariler than expectation. Signed-off-by: Qu Wenruo <wqu@suse.com> --- tests/btrfs/213 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)