| Message ID | 20240507023417.31796-1-yaolu@kylinos.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | btrfs: scrub: fix a compilation warning | expand |
On Tue, May 07, 2024 at 10:34:17AM +0800, Lu Yao wrote: > The following error message is displayed: > ../fs/btrfs/scrub.c:2152:9: error: ‘ret’ may be used uninitialized > in this function [-Werror=maybe-uninitialized]" > > Signed-off-by: Lu Yao <yaolu@kylinos.cn> Reviewed-by: Boris Burkov <boris@bur.io> > --- > gcc version: (Debian 10.2.1-6) 10.2.1 20210110 > --- > fs/btrfs/scrub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c > index 4b22cfe9a98c..afd6932f5e89 100644 > --- a/fs/btrfs/scrub.c > +++ b/fs/btrfs/scrub.c > @@ -2100,7 +2100,7 @@ static int scrub_simple_mirror(struct scrub_ctx *sctx, > struct btrfs_fs_info *fs_info = sctx->fs_info; > const u64 logical_end = logical_start + logical_length; > u64 cur_logical = logical_start; > - int ret; > + int ret = 0; > > /* The range must be inside the bg */ > ASSERT(logical_start >= bg->start && logical_end <= bg->start + bg->length); > -- > 2.25.1 >
On Tue, May 07, 2024 at 10:34:17AM +0800, Lu Yao wrote: > The following error message is displayed: > ../fs/btrfs/scrub.c:2152:9: error: ‘ret’ may be used uninitialized > in this function [-Werror=maybe-uninitialized]" > > Signed-off-by: Lu Yao <yaolu@kylinos.cn> > --- > gcc version: (Debian 10.2.1-6) 10.2.1 20210110 The compiler version should be in the changelog as we want to know which version produces the warning, but otherwise ok. Patch added to for-next, thanks.
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 4b22cfe9a98c..afd6932f5e89 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -2100,7 +2100,7 @@ static int scrub_simple_mirror(struct scrub_ctx *sctx, struct btrfs_fs_info *fs_info = sctx->fs_info; const u64 logical_end = logical_start + logical_length; u64 cur_logical = logical_start; - int ret; + int ret = 0; /* The range must be inside the bg */ ASSERT(logical_start >= bg->start && logical_end <= bg->start + bg->length);
The following error message is displayed: ../fs/btrfs/scrub.c:2152:9: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]" Signed-off-by: Lu Yao <yaolu@kylinos.cn> --- gcc version: (Debian 10.2.1-6) 10.2.1 20210110 --- fs/btrfs/scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)