| Message ID | 20241010153630.1225162-1-maharmstone@fb.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | btrfs/318: add _require_loop | expand |
On Thu, Oct 10, 2024 at 4:46 PM Mark Harmstone <maharmstone@fb.com> wrote: > > btrfs/318 uses loopback devices, but was missing a call to _require_loop > to print the correct message if CONFIG_LOOP is not set. > > Signed-off-by: Mark Harmstone <maharmstone@fb.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Looks good, thanks. > --- > tests/btrfs/318 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/btrfs/318 b/tests/btrfs/318 > index 79977276..df5a4a07 100755 > --- a/tests/btrfs/318 > +++ b/tests/btrfs/318 > @@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \ > _require_test > _require_command "$PARTED_PROG" parted > _require_batched_discard "$TEST_DIR" > +_require_loop > > _cleanup() { > cd / > -- > 2.44.2 > >
On Thu, Oct 10, 2024 at 04:36:25PM +0100, Mark Harmstone wrote: > btrfs/318 uses loopback devices, but was missing a call to _require_loop > to print the correct message if CONFIG_LOOP is not set. > > Signed-off-by: Mark Harmstone <maharmstone@fb.com> > --- > tests/btrfs/318 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/btrfs/318 b/tests/btrfs/318 > index 79977276..df5a4a07 100755 > --- a/tests/btrfs/318 > +++ b/tests/btrfs/318 > @@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \ > _require_test > _require_command "$PARTED_PROG" parted > _require_batched_discard "$TEST_DIR" > +_require_loop Sure, this case need loop device. Reviewed-by: Zorro Lang <zlang@redhat.com> > > _cleanup() { > cd / > -- > 2.44.2 > >
diff --git a/tests/btrfs/318 b/tests/btrfs/318 index 79977276..df5a4a07 100755 --- a/tests/btrfs/318 +++ b/tests/btrfs/318 @@ -18,6 +18,7 @@ _fixed_by_kernel_commit 9f7eb8405dcb \ _require_test _require_command "$PARTED_PROG" parted _require_batched_discard "$TEST_DIR" +_require_loop _cleanup() { cd /
btrfs/318 uses loopback devices, but was missing a call to _require_loop to print the correct message if CONFIG_LOOP is not set. Signed-off-by: Mark Harmstone <maharmstone@fb.com> --- tests/btrfs/318 | 1 + 1 file changed, 1 insertion(+)