From patchwork Wed Apr 11 08:29:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Misono Tomohiro X-Patchwork-Id: 10335071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5FA316053B for ; Wed, 11 Apr 2018 08:29:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C5742878C for ; Wed, 11 Apr 2018 08:29:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F8DE2878F; Wed, 11 Apr 2018 08:29:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A865B2878C for ; Wed, 11 Apr 2018 08:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbeDKI31 (ORCPT ); Wed, 11 Apr 2018 04:29:27 -0400 Received: from mgwkm04.jp.fujitsu.com ([202.219.69.171]:61148 "EHLO mgwkm04.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbeDKI30 (ORCPT ); Wed, 11 Apr 2018 04:29:26 -0400 Received: from kw-mxoi1.gw.nic.fujitsu.com (unknown [192.168.231.131]) by mgwkm04.jp.fujitsu.com with smtp id 5c24_7877_985f7bab_ebc2_4dd7_a057_2d0d3a297e12; Wed, 11 Apr 2018 17:29:21 +0900 Received: from g01jpfmpwyt02.exch.g01.fujitsu.local (g01jpfmpwyt02.exch.g01.fujitsu.local [10.128.193.56]) by kw-mxoi1.gw.nic.fujitsu.com (Postfix) with ESMTP id D6C18AC0231 for ; Wed, 11 Apr 2018 17:29:20 +0900 (JST) Received: from G01JPEXCHYT13.g01.fujitsu.local (G01JPEXCHYT13.g01.fujitsu.local [10.128.194.52]) by g01jpfmpwyt02.exch.g01.fujitsu.local (Postfix) with ESMTP id 3F0DF584319 for ; Wed, 11 Apr 2018 17:29:20 +0900 (JST) X-SecurityPolicyCheck: OK by SHieldMailChecker v2.5.2 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20170217-enc X-SHieldMailCheckerMailID: 77cfa5e2f4554595a65a87cb7c69e81a From: Misono Tomohiro Subject: [PATCH] btrfs-progs: configure: check if xmlto exists at configure time To: linux-btrfs Message-ID: <29b3fdcb-afbc-b3b3-41c3-825f778ccecd@jp.fujitsu.com> Date: Wed, 11 Apr 2018 17:29:00 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US X-SecurityPolicyCheck-GC: OK by FENCE-Mail X-TM-AS-MML: disable Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP AC_PATH_PROG won't fail even if it fails to find command path. xmlto is required for document build and we should report error if it doesn't exist at configure time. Signed-off-by: Tomohiro Misono Reviewed-by: Qu Wenruo --- configure.ac | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index af13a959..a4c98b31 100644 --- a/configure.ac +++ b/configure.ac @@ -93,7 +93,11 @@ AC_SUBST([DISABLE_DOCUMENTATION]) dnl detect tools to build documentation ASCIIDOC_TOOL="none" if test "x$enable_documentation" = xyes; then - AC_PATH_PROG([XMLTO], [xmlto], [xmlto]) + AC_PATH_PROG([XMLTO], [xmlto]) + if test -z "$XMLTO"; then + AC_MSG_ERROR([cannot find xmlto, cannot build documentation]) + fi + AC_PATH_PROG([GZIP], [gzip], [gzip]) AC_PATH_PROG([MV], [mv], [mv]) AC_PROG_SED