From patchwork Fri Oct 11 04:17:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anand Jain X-Patchwork-Id: 13832037 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D7F322E for ; Fri, 11 Oct 2024 04:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728620268; cv=fail; b=b4Mk1iRe0dmXAla1LyxKR5rbkFyGZGY6AVxyXDbvDOM9O9T9HSxw9IuOQ4INLqAhUhl8YGA3c0DOL0+IYzrGUVnOb8DD9bE6wNQXMkaqE0h81UpFYZwKMr/USlihbfraOkzonLZl7WSkXCltmAabewVV7qUCS3DuPus07l323gw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728620268; c=relaxed/simple; bh=CKyvzDovqVssoP9edIVoDrH+vQUYppwPxMGhzAbfGdc=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=TV+ccS32cdZGCkP/R+X6pHUUDWF1+K/GIr63S9GRAzZ+keIeFiE3a7OrSawMQzutNzZXz3SWit0vPOXcUgyYa/xffWx01p+EqgpeZUf6IsPr4jvCuL5IBRNr4eOV0yUztvWLcO1yU4/E6Hz64HD8LSDsjez4RRUsQ864tK7LQk8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=YOWVx+T4; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=BSghggCA; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="YOWVx+T4"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="BSghggCA" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49AJtdSA012144 for ; Fri, 11 Oct 2024 04:17:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=ZYxz1LwjCRNZME3B kvC/983bh/uNgU/iFAgRdp+O+5w=; b=YOWVx+T4WnPgiTjoFVlFLd1k13Luu5bS QCtwBpXe1IZZBiYi614uLH6U0AWx3Bnjxv7T5PtSicGVtuyCeI9CFXWLpw3dEVeQ 6lR5e+OaonrWOEBYL0Mydsauz4oLQ8OtKyQM3eT8BBd8zbwwG66RJe10Xrcsi363 QRrIxTXptxLo4WRnZ4cYz/GtxEi+Dlf/J7eZMCqX1TfduuFnsVmEDtKfA1paxTp7 QoLFWNlRG6iFfVAv9XFilp1axPdABuMk7nntZEfyStCQUeKFn86WBzSBJ5PqwruG /ztL2m3FR6Es7TTA/VlFe4fRcBwCSg+PiytOrqVNrP2m69z8Edq/ew== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42302pkxsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 11 Oct 2024 04:17:45 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49B39OWA034287 for ; Fri, 11 Oct 2024 04:17:44 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2046.outbound.protection.outlook.com [104.47.56.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 422uwavene-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 11 Oct 2024 04:17:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E8I8bIbHXY16HmevbZIrXQA7scekSQIHdgfwi1FCiXU/3Z4EfCZL2fwmdchTgAPsuAoWxVCscTDSSWDD+LYYlhtieRcUCzuOawS3k+XRS7vuCKXDxzW8hgyUZixKkJN9HzKTOOokmedKz7zJG0t6uMMZCglRoZC2Io3dk6PgNSSjcpvpvt5LjlwzAyrzd13u6DcYHM7Cg+XaTtVOwZgNBxoUczZi5eRm3J4pCdfxrUuhH+v3ebovviz7ZBENWkCakwAL95Ki0T5j99XlICvr7f20oWrQU6yKHkFdYbgBNDIbal/WBYurRt/IgpY0J+D63KGbD+8artqXnvndT+GSkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZYxz1LwjCRNZME3BkvC/983bh/uNgU/iFAgRdp+O+5w=; b=Bg2GuDhP6FlNkAhgcgEuIYwMMKd7az6mhY0u7jIhpSf048NvH5/uqsVhHcLm8qaXUbkrH6pkeKixWxdx96krDk0HN9nMVV1iBr2qlwAsfTWbhAjlq7FOfEl7eWtwOHs2Or3Lr1tDrZFprcpEWD/k4AUgMGu/rsFQiiSQD2DxS0zdW2nNjarvHQ+PSZq0BrSR6cnmL+pjM6Y/bhv1HCKPwahmtj/DZYKAwBC407CofXCjZHU3wipr84JV1kxMfvRFUg9GXoOmBJLyvKH1dsuR1tTaddU8Y0oPZnKXnksVxezp6yJP7hT/D2Agb5RMO8oWyaHfezssJXZcZx4OKCPHag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZYxz1LwjCRNZME3BkvC/983bh/uNgU/iFAgRdp+O+5w=; b=BSghggCA3CDexKerW0EQVY4zA5mJZRnitxrpDRVKRAUuDutLp8g20gKBQH85998mOIX30+X6Ci030XTFRKez1n0izgwMlK0bqSBepqll2NmlZbCHVtEnoeiVqn6JH9j5XoU1Toht4tTap7S7D0eOwTZCwZn2hmqMkPLlRjZGZVA= Received: from PH0PR10MB5706.namprd10.prod.outlook.com (2603:10b6:510:148::10) by DM4PR10MB6864.namprd10.prod.outlook.com (2603:10b6:8:103::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Fri, 11 Oct 2024 04:17:42 +0000 Received: from PH0PR10MB5706.namprd10.prod.outlook.com ([fe80::fea:df00:2d94:cb65]) by PH0PR10MB5706.namprd10.prod.outlook.com ([fe80::fea:df00:2d94:cb65%5]) with mapi id 15.20.8048.013; Fri, 11 Oct 2024 04:17:41 +0000 From: Anand Jain To: linux-btrfs@vger.kernel.org Subject: [PATCH] btrfs-progs: fix usage warning in common/help.c Date: Fri, 11 Oct 2024 12:17:19 +0800 Message-ID: <3ec35c42add1b57d547c9cbd90213a645c7335c9.1728459736.git.anand.jain@oracle.com> X-Mailer: git-send-email 2.46.1 X-ClientProxiedBy: SI2PR02CA0020.apcprd02.prod.outlook.com (2603:1096:4:195::7) To PH0PR10MB5706.namprd10.prod.outlook.com (2603:10b6:510:148::10) Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5706:EE_|DM4PR10MB6864:EE_ X-MS-Office365-Filtering-Correlation-Id: eb06109e-38e5-4ca1-2d8b-08dce9aba62b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?q?M3d6SGn6DFlYlcLpwwXg1HE2uXRDR7p?= =?utf-8?q?FUNSPC2MTi55Pm3aH9yA9PKF/QVsmUqGTwCAyRL8U+3HJij6ZO9HT4ji92388hOv/?= =?utf-8?q?Cm1GygYwQJEwXQBjVlI4khgN85UhUm7IrxCxDUt3O9Ksg2Z+710/vGrnSY0YFGjwK?= =?utf-8?q?gRDCfLFiLLV0ioG3WuFCkw/kyN9ggJgJX/hBarRmWDbRNZgplXmSnDnyAzzeM5Uch?= =?utf-8?q?owWAhmFx6r7xZXD7LWaW1ESKr0ateQTxNnqnNNGBPwozAYkzD9ahdsX5vtR6/5cGt?= =?utf-8?q?5iuTFatxX0t4VGXhn0Zhv++BSmi5e/4LzN3unTWaV/ClO3Y8rJaaBTTFh01VkCbAi?= =?utf-8?q?CVWbGc0hcXuNPJikIGZP0bzq1fcZw2huYeoSQoA8kOlpL7cfmE9Q+i16BtpvogBVe?= =?utf-8?q?sNddZqPE1KVAE/uZBNfNDXP2kpgznJX5YjQT8cM/YgTGUo1+MK1/o5Nr4kJ/Gp9wv?= =?utf-8?q?8RqFr1TE10HkBX4lWBM00nKXroyO5JaJy2ARZCADnlgSDyulVilD23RVolka/Z27Z?= =?utf-8?q?8AdvSp8QNmROiBdgkAXCKnf+gQsP9TfQRMbd22xtFrynU8xte8UZdTGQ1SMcJOfms?= =?utf-8?q?vc760EMqA5MP7T++UPyQVeBRkQn9aKEt9MKU8TsANoc8TrVg48o1Q3wNCwIL4KSQJ?= =?utf-8?q?+NdLGKglV4V+PU/mawL/4OD9Bt6qNzV9RmskO54UETKsJ22swJUAemsjvqgavj927?= =?utf-8?q?HkRp/MECh579LKiPV1eoV5n98gzxi6YHYTJIA12Anrym2snXGzbrTQPKlAxZUm6fV?= =?utf-8?q?5TMiPWKQ5M4jGX06G3/quMAqxJMHiGWZK4GYFhaXLM7aQFTobdolDQKTUpNtd408k?= =?utf-8?q?v5doLKVluHX9jM6N65zU9IVE1lUu0exL1wkPDATvYv3e5jxxvQ9+DRAmNjP5FUnwW?= =?utf-8?q?Int5RnGCXuyZqOHzYMQCStcAXuii3rwBgEopIjz2ML2PvKafhVc9m8qGJaLSCXaCf?= =?utf-8?q?qHOfohp8kfF6tP0Fbza4UZeGJ+PQ64CL1zoVXRH30h880ImXroV3qKyU4QQ17kPWV?= =?utf-8?q?fTRsU8IviRqlLOliKdck7TYm7/0tMYUEyYSMCA+pfyJI6Ib1IVO2WxoDM8YsZzk6m?= =?utf-8?q?BExCIDzjxjdMeVqKTuItnmb9BLUa5DOAVnNLTf/Z6X0FhVHKFxUZVPDTt0w0jUEjB?= =?utf-8?q?R9E+XHs0ExrGkDrejuWCtrFfHv7qMh5XqyKYMqsY2sWnQ5tptj5dGI+Cjnve4WxrB?= =?utf-8?q?5zNK+Gt3IYb7qAIm6cPJkLOtg1J8JQOIQO/Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5706.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?F6p/JFhWKcP1+Iy5n3CF1lSv/5WR?= =?utf-8?q?fbC/uSUtBlKXxSU2bUJy1x+CFBCF+EsKl5bctDEts0MyUGXT7xef3sHkCrHkpnHV/?= =?utf-8?q?TLcxm359lNi92yBI+G5FLOdjp2cWsSh3+q73czag54duCeX1Lz/JQ8i5TfbFuuIYK?= =?utf-8?q?HuNo4cfZOdKMmYTl9TGguytcENdCxSG+AS/T93vCQCmLzXli5Bw1DEBTdvyMnG6yU?= =?utf-8?q?9NlbgViMRrqhLwKVJMf0DSHg0izQNoAltFZpIXens9cEzdu6NeRhuVWVmbX1HlOfe?= =?utf-8?q?IbvioJt/xNzKug1XrMFVj6lgbFWLgu+1oCJzbIMg06LV2aWNXHvI98o3cvWmmZed+?= =?utf-8?q?FLrWcKxpUSOlbpc+2Hc36A2Bw+hy0iOVJxw1HiP0eMZCzfKW//XaWd3mrprwbI9c6?= =?utf-8?q?AGz6pbMSfbzAiydMgZqhEX/eJop29aaAW/q1sRXfHnrFk3b0PKA8mBUYqYs/sVOaz?= =?utf-8?q?Gx706YRag2Ds++Ym/nE1gCHDxPfTVbMSLo4UCHwhHtTpeGrTMi7okAGxg2zTKVSeg?= =?utf-8?q?lhFBn9jPBMIZussIJFmVGzzrPXy6A3AqODZXR/+fzV1D/Kd8DkBFsHD1UFc5OT657?= =?utf-8?q?D4WORlEfOPq/Zys0j8Sf9SEjx0hZLEC0S3GiQN4c+ZXjrMrCicLgpJJeFkh6I1FU+?= =?utf-8?q?XGoj/YCmtXT3/qECo8263EGIOyz2gEUmGajtlifTabybyjtF37o+h1ukIJyzTCB0Z?= =?utf-8?q?ybnD9qzkJvt4f2JJJAIkxZzvdQJFAnFs39oXiPaGZPIRTdzacT0IB5UIy71XXi4zR?= =?utf-8?q?sDYNFhqz+fIOxDy/v8PB+qFuKZcFIqnYKAxpklfNYh1f94x2R36eqJdHucomsSseG?= =?utf-8?q?uysPptoQDBKxweTRzWL0GlM6VQijcS1/yGgGdCZ+gdxusMahgvwrh7VYJAdyb4IfR?= =?utf-8?q?yUUJbQ8SUfENcAGwy+0Bi/q5qZttS/e7xEXiE+cvqbqNkFFEqjgm75o1sEQAHje9U?= =?utf-8?q?i8Ba575okTnWHXZODOou7TNrK9bLVglJLmP/mTPGTBkYuangirWCelh/1ElgENhlc?= =?utf-8?q?fcHa4T1/nwJXjlLSJlEOQ3oSiYT0nsUZ37w/Cn00A3MveaumGCZMt3TLRPE8aqGUt?= =?utf-8?q?ucgrlkYZT3W6jFN2tvuev0rqWcApkJnk1UvZYvBeX2pxD3rjAcnRSZAdHsHFNeG1w?= =?utf-8?q?ytmquCadRTN9W8zoipWSsF2x2A5WohMhJyYitA0Y9WIqFgzuvgnnkIT3G+Kzl8KR5?= =?utf-8?q?EE9Pgr7F8PgBpS6kBiPL/Ff8ntaYwMwjcOsVzHS7yQC6MRz43AOlnhuvGminnjjVm?= =?utf-8?q?vYAPE2k2qk8E19wfbf0yIXRCFMDpv/FfzR/xGAN/TUaVgoJNxsSD2pVBJiV4bcrs7?= =?utf-8?q?9ZffKVAFu362mKYX5vMXqsVdv/R+J/LDnZSzV5eh2B6BgvkOLciFa9iHTeTdyXLoX?= =?utf-8?q?NCjDJqkfsN+lIicGcT3fr0zxvqHtrebdreEy+0XLc0iRwhEZwazP7GHnVNfrQ2o8p?= =?utf-8?q?NugyMmPjLc/eeX4ehEOaH7/C0fMoDYi9I5Aq00Kvzp1MpYIusLx9S8IYAoaQkIKw1?= =?utf-8?q?xs0mwaXi4zWc?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Tc9gwpbrdnQkMditqEsdmPtwERDncf5PBeCpIPYRTlL7N2OZMt7GUS/V9BGWuFwP7qXine7sVAnpB0hnb/3VKywHoznzS6X9wwj2nmouIDUjrqpjG7DcCpHeWQZ1BcBC1nM+XGtPw1q4On3i+S1VXTRTP+9A4PShDN5QtZdAUyEksX/7ZAeiDQtQ8Apc3ew4clsKesOULh5T7g4a4sIIuWTtEae/Kjqo/wkIhT3aiRwpmbA1w6dD2URrHHM2/FiRoJlgEIAO/72nO6cZ3+Bi8dbzZHyohIsOHR6XS4aqmo7JJtvf176Bsi68raF9HXVrk3ZzHXQR6wO5h01m6qIOlCC4DcPlKkZau8uCdbxoYBR3+x+wqwUC94grR67SJCq9NrqJn9Hy7jZmGC3yf0dXRU1jykoT/nwxs4XalAuezoJhE1r0pn18j/eLgIqSVsgywcE+EUM7YAEOjwMkabQekdgwz3gfD6n1nRBcB0/0oHKSwIfOXhzJk3sssltEAIQV6DJd7OwJCfvT+Tpxw7ObwGrMZo0B9km5uhsJnf9XaWzzv8keNKVDwOVW/m6uyF7hl8pAGsf6bK62wZZd5gpR/7XmjA8sezR2uStIj3uBMr0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb06109e-38e5-4ca1-2d8b-08dce9aba62b X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2024 04:17:41.8970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VKwjhD8wQWsWVHPdl7hDsQlYiwH3P1ugOVbcqy8F/WdQwjtjr0yk2rHnfrIaDmUtE7T9gOrM6qKrqA0U9WV77Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6864 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-10_19,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410110024 X-Proofpoint-ORIG-GUID: _GktzPWtuMXDqRxu7sTxxJOsxmPtr1W- X-Proofpoint-GUID: _GktzPWtuMXDqRxu7sTxxJOsxmPtr1W- On systems with glibc 2.34 and 2.39, the following warning appears when building the binary, causing concern that something has failed. [CC] common/help.o common/help.c: In function ‘usage’: common/help.c:315:58: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 315 | fprintf(outf, "No short description for '%s'\n", token); | ^~ common/help.c:312:46: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 312 | fprintf(outf, "No usage for '%s'\n", token); | ^~ The compiler warns that in some code paths, the token is `NULL`. Silence the warning by checking if the token is `NULL`. Signed-off-by: Anand Jain Reviewed-by: Qu Wenruo --- common/help.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/help.c b/common/help.c index 6cf8e2a9b2ae..eff9aac537db 100644 --- a/common/help.c +++ b/common/help.c @@ -309,10 +309,11 @@ static int usage_command_internal(const char * const *usagestr, ret = do_usage_one_command(usagestr, flags, cmd_flags, outf); switch (ret) { case -1: - fprintf(outf, "No usage for '%s'\n", token); + fprintf(outf, "No usage for '%s'\n", token ? token : ""); break; case -2: - fprintf(outf, "No short description for '%s'\n", token); + fprintf(outf, "No short description for '%s'\n", + token ? token : ""); break; }