| Message ID | 4DDD57B5.4070309@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 25.05.2011 um 21:25 schrieb Josef Back: > > Hrm well that's doubly weird, the root should be right so it should be > able to find the orphan item to delete it for the bad inode, and why the > hell are we looping on that orphan item? Remove the previous patch I > gave you and apply this one instead and run with this please and provide > me the log. Sorry in advance, it will likely give you a giant log file > again. Thanks, The system didn't crash until now and all I got in the log was the following output. This is the expected correct behavior? May 26 03:10:13 mainframe kernel: found orphan item for 909457 on 267 May 26 03:10:13 mainframe kernel: lookup of inode was from disk May 26 03:10:13 mainframe kernel: inode needs to be truncated May 26 03:10:13 mainframe kernel: drop is 0 May 26 03:10:13 mainframe kernel: found orphan item for 909415 on 267 May 26 03:10:13 mainframe kernel: lookup of inode was from disk May 26 03:10:13 mainframe kernel: inode needs to be unlinked May 26 03:10:13 mainframe kernel: drop is 1 May 26 03:10:13 mainframe kernel: found orphan item for 909414 on 267 May 26 03:10:13 mainframe kernel: lookup of inode was from disk May 26 03:10:13 mainframe kernel: inode needs to be unlinked May 26 03:10:13 mainframe kernel: drop is 1 May 26 03:10:13 mainframe kernel: found orphan item for 899452 on 267 May 26 03:10:13 mainframe kernel: lookup of inode was from disk May 26 03:10:13 mainframe kernel: inode needs to be unlinked May 26 03:10:13 mainframe kernel: drop is 1 May 26 03:10:13 mainframe kernel: found orphan item for 899451 on 267 May 26 03:10:13 mainframe kernel: lookup of inode was from disk May 26 03:10:13 mainframe kernel: inode needs to be unlinked May 26 03:10:13 mainframe kernel: drop is 1 May 26 03:10:13 mainframe kernel: btrfs: unlinked 4 orphans May 26 03:10:13 mainframe kernel: btrfs: truncated 1 orphans May 26 03:10:46 mainframe kernel: drop is 0 I'll keep an eye on it. -marco -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/27/2011 03:23 PM, Marco Neubauer wrote: > > Am 25.05.2011 um 21:25 schrieb Josef Back: >> >> Hrm well that's doubly weird, the root should be right so it should be >> able to find the orphan item to delete it for the bad inode, and why the >> hell are we looping on that orphan item? Remove the previous patch I >> gave you and apply this one instead and run with this please and provide >> me the log. Sorry in advance, it will likely give you a giant log file >> again. Thanks, > > The system didn't crash until now and all I got in the log was the following output. > This is the expected correct behavior? > Well I was expecting a panic message and such, but if you didn't get any of that I'm stumped. I guess this means you've gotten past the mount section and are able to run for a while before it blows up? Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h index 4bc852d..d85a309 100644 --- a/fs/btrfs/btrfs_inode.h +++ b/fs/btrfs/btrfs_inode.h @@ -149,6 +149,7 @@ struct btrfs_inode { unsigned ordered_data_close:1; unsigned orphan_meta_reserved:1; unsigned dummy_inode:1; + unsigned orphaned:1; /* * always compress this one file diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 5fa0ae7..a49f848 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -2314,6 +2314,8 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) key.offset = (u64)-1; while (1) { + int new; + ret = btrfs_search_slot(NULL, root, &key, path, 0, 0); if (ret < 0) goto out; @@ -2340,6 +2342,9 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) if (btrfs_key_type(&found_key) != BTRFS_ORPHAN_ITEM_KEY) break; + printk(KERN_ERR "found orphan item for %llu on %llu\n", + found_key.offset, root->root_key.objectid); + /* release the path since we're done with it */ btrfs_release_path(root, path); @@ -2351,12 +2356,15 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) found_key.objectid = found_key.offset; found_key.type = BTRFS_INODE_ITEM_KEY; found_key.offset = 0; - inode = btrfs_iget(root->fs_info->sb, &found_key, root, NULL); + inode = btrfs_iget(root->fs_info->sb, &found_key, root, &new); if (IS_ERR(inode)) { ret = PTR_ERR(inode); goto out; } + printk(KERN_ERR "lookup of inode was%s from disk", + new ? "" : " not"); + BTRFS_I(inode)->orphaned = 1; /* * add this inode to the orphan list so btrfs_orphan_del does * the proper thing when we hit it @@ -2372,6 +2380,8 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) * do a destroy_inode */ if (is_bad_inode(inode)) { + printk(KERN_ERR "%llu is a bad inode, root is %llu\n", + inode->i_ino, BTRFS_I(inode)->root->root_key.objectid); trans = btrfs_start_transaction(root, 0); if (IS_ERR(trans)) { ret = PTR_ERR(trans); @@ -2385,7 +2395,10 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) /* if we have links, this was a truncate, lets do that */ if (inode->i_nlink) { + printk(KERN_ERR "inode needs to be truncated\n"); if (!S_ISREG(inode->i_mode)) { + printk(KERN_ERR "file mode is %lu, nlink is " + "%lu\n", inode->i_mode, inode->i_nlink); WARN_ON(1); iput(inode); continue; @@ -2393,6 +2406,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) nr_truncate++; ret = btrfs_truncate(inode); } else { + printk(KERN_ERR "inode needs to be unlinked\n"); nr_unlink++; } @@ -3755,10 +3769,18 @@ void btrfs_evict_inode(struct inode *inode) truncate_inode_pages(&inode->i_data, 0); if (inode->i_nlink && (btrfs_root_refs(&root->root_item) != 0 || - root == root->fs_info->tree_root)) + root == root->fs_info->tree_root)) { + if (BTRFS_I(inode)->orphaned) + printk(KERN_ERR "inode->i_nlink=%d, btrfs_root_refs=%d, " + "root==tree_root=%s\n", inode->i_nlink, + btrfs_root_refs(&root->root_item), + (root == root->fs_info->tree_root) ? "yes" : "no"); goto no_delete; + } if (is_bad_inode(inode)) { + if (BTRFS_I(inode)->orphaned) + printk(KERN_ERR "bad inode\n"); btrfs_orphan_del(NULL, inode); goto no_delete; } @@ -3771,6 +3793,8 @@ void btrfs_evict_inode(struct inode *inode) } if (inode->i_nlink > 0) { + if (BTRFS_I(inode)->orphaned) + printk(KERN_ERR "inode->i_nlink=%d\n", inode->i_nlink); BUG_ON(btrfs_root_refs(&root->root_item) != 0); goto no_delete; } @@ -3805,6 +3829,8 @@ void btrfs_evict_inode(struct inode *inode) if (ret == 0) { ret = btrfs_orphan_del(trans, inode); BUG_ON(ret); + } else if (BTRFS_I(inode)->orphaned) { + printk(KERN_ERR "truncate failed %d\n", ret); } nr = trans->blocks_used; @@ -6859,6 +6885,7 @@ struct inode *btrfs_alloc_inode(struct super_block *sb) ei->ordered_data_close = 0; ei->orphan_meta_reserved = 0; ei->dummy_inode = 0; + ei->orphaned = 0; ei->force_compress = BTRFS_COMPRESS_NONE;