| Message ID | 505FAD9B.7010006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 24 Sep 2012, Wang Sheng-Hui wrote: > In the big loop, cur_trans will be set fs_info->running_transaction > before it's used. And after kmem_cache_free it and goto loop, it will > be setup again. No need to setup it immediately after freed. > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > fs/btrfs/transaction.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c > index 469a8b6..675d813 100644 > --- a/fs/btrfs/transaction.c > +++ b/fs/btrfs/transaction.c > @@ -98,7 +98,6 @@ loop: > * to redo the trans_no_join checks above > */ > kmem_cache_free(btrfs_transaction_cachep, cur_trans); > - cur_trans = fs_info->running_transaction; > goto loop; > } else if (fs_info->fs_state & BTRFS_SUPER_FLAG_ERROR) { > spin_unlock(&fs_info->trans_lock); This is Obviously Correct(TM) :-) and doesn't seem to have been picked up by btrfs maintainers. I am picking it up now.
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index 469a8b6..675d813 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -98,7 +98,6 @@ loop: * to redo the trans_no_join checks above */ kmem_cache_free(btrfs_transaction_cachep, cur_trans); - cur_trans = fs_info->running_transaction; goto loop; } else if (fs_info->fs_state & BTRFS_SUPER_FLAG_ERROR) { spin_unlock(&fs_info->trans_lock);
In the big loop, cur_trans will be set fs_info->running_transaction before it's used. And after kmem_cache_free it and goto loop, it will be setup again. No need to setup it immediately after freed. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/btrfs/transaction.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)