From patchwork Fri Dec 21 10:38:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miao Xie X-Patchwork-Id: 1902821 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D3057DF25A for ; Fri, 21 Dec 2012 11:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673Ab2LULCq (ORCPT ); Fri, 21 Dec 2012 06:02:46 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:47937 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750869Ab2LULCp (ORCPT ); Fri, 21 Dec 2012 06:02:45 -0500 X-IronPort-AV: E=Sophos;i="4.84,330,1355068800"; d="scan'208";a="6448811" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 21 Dec 2012 19:00:49 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id qBLAe8Rj031105 for ; Fri, 21 Dec 2012 18:40:08 +0800 Received: from [10.167.225.199] ([10.167.225.199]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2012122118371896-554461 ; Fri, 21 Dec 2012 18:37:18 +0800 Message-ID: <50D43C3A.7090608@cn.fujitsu.com> Date: Fri, 21 Dec 2012 18:38:50 +0800 From: Miao Xie Reply-To: miaox@cn.fujitsu.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Linux Btrfs Subject: [PATCH V2 1/3] Btrfs: fix missing write access release in btrfs_ioctl_resize() References: <50D42998.1010100@cn.fujitsu.com> In-Reply-To: <50D42998.1010100@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/21 18:37:18, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/12/21 18:37:19, Serialize complete at 2012/12/21 18:37:19 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org We forget to give up the write access after we find some device operation is going on. Fix it. Signed-off-by: Miao Xie --- Changelog v1 -> v2: - don't break the string --- fs/btrfs/ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 7624212..d6f43fa 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1339,6 +1339,7 @@ static noinline int btrfs_ioctl_resize(struct file *file, if (atomic_xchg(&root->fs_info->mutually_exclusive_operation_running, 1)) { pr_info("btrfs: dev add/delete/balance/replace/resize operation in progress\n"); + mnt_drop_write_file(file); return -EINPROGRESS; }