WARNING at fs/btrfs/backref.c:936 find_parent_nodes+0x378/0x5d2

Commit Message

Wang Shilong Jan. 20, 2014, 8:41 a.m. UTC

Hello Tomasz,

On 01/20/2014 05:46 AM, Tomasz Chmielewski wrote:
> No balance was running. The usual rsync and btrfs snapshots; I'm unable
> to say when exactly it happened (i.e. if it was during rsync or snapshot
> adding/removal).
>
> As of defragment - I didn't run it manually, but I have autodefrag
> option enabled:
Would you please try attached patch and see if problem happen again.:-)

Thanks,
Wang
>
> /dev/sdc1 on /mnt/lxc2 type btrfs
> (rw,noatime,compress-force=zlib,space_cache,autodefrag)
>
>

Patch

From a97bab00f5351182962655901b8fb045ae7cf5ac Mon Sep 17 00:00:00 2001
From: Wang Shilong <[e-mail]>
Date: Mon, 20 Jan 2014 15:17:45 +0800
Subject: [PATCH] Btrfs: release path after adding missing keys

Signed-off-by: Wang Shilong <[e-mail]>
---
 fs/btrfs/backref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index d059cc8..b0ce27a 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -931,13 +931,13 @@  again:
 				goto out;
 		}
 	}
-	btrfs_release_path(path);
 
 	list_splice_init(&prefs_delayed, &prefs);
 
 	ret = __add_missing_keys(fs_info, &prefs);
 	if (ret)
 		goto out;
+	btrfs_release_path(path);
 
 	__merge_refs(&prefs, 1);
 
-- 
1.8.3.1