diff mbox

Btrfs: Remove unnecessary placeholder in btrfs_err_code

Message ID 549A5484.9000202@jp.fujitsu.com (mailing list archive)
State Under Review
Headers show

Commit Message

Satoru Takeuchi Dec. 24, 2014, 5:52 a.m. UTC 
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

"notused" is not necessary. Set 1 to the first entry is enough.

Signed-off-by: Takeuchi Satoru <takeuchi_satoru@jp.fujitsu.com
Cc: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
---
I once submit the similar patch to btrfs-progs.
Then Gui Hecheng tell me fixing original code in kernel
is better.

http://permalink.gmane.org/gmane.comp.file-systems.btrfs/41679
---
 include/uapi/linux/btrfs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Sterba Dec. 29, 2014, 2:13 p.m. UTC | #1 
On Wed, Dec 24, 2014 at 02:52:04PM +0900, Satoru Takeuchi wrote:
> I once submit the similar patch to btrfs-progs.
> Then Gui Hecheng tell me fixing original code in kernel
> is better.

The kernel header is exported and the authoritative source for the ioctl
definitions, progs usually copy the required portions but should be
identical in the end.

Reviewed-by: David Sterba <dsterba@suse.cz>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 611e1c5..b6dec05 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -495,8 +495,7 @@  struct btrfs_ioctl_send_args {
 
 /* Error codes as returned by the kernel */
 enum btrfs_err_code {
-	notused,
-	BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET,
+	BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET = 1,
 	BTRFS_ERROR_DEV_RAID10_MIN_NOT_MET,
 	BTRFS_ERROR_DEV_RAID5_MIN_NOT_MET,
 	BTRFS_ERROR_DEV_RAID6_MIN_NOT_MET,