From patchwork Mon Mar 7 03:05:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satoru Takeuchi X-Patchwork-Id: 8514821 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 06ECB9F9A0 for ; Mon, 7 Mar 2016 03:06:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 26E8A2013A for ; Mon, 7 Mar 2016 03:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E6102012B for ; Mon, 7 Mar 2016 03:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbcCGDGc (ORCPT ); Sun, 6 Mar 2016 22:06:32 -0500 Received: from mgwym01.jp.fujitsu.com ([211.128.242.40]:57586 "EHLO mgwym01.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbcCGDGb (ORCPT ); Sun, 6 Mar 2016 22:06:31 -0500 Received: from yt-mxoi2.gw.nic.fujitsu.com (unknown [192.168.229.69]) by mgwym01.jp.fujitsu.com with smtp id 5793_2695_47a5d6e4_f497_4869_a2f9_b57ff5d363bb; Mon, 07 Mar 2016 12:06:24 +0900 Received: from m3050.s.css.fujitsu.com (msm.b.css.fujitsu.com [10.134.21.208]) by yt-mxoi2.gw.nic.fujitsu.com (Postfix) with ESMTP id 6DCB3AC01E3 for ; Mon, 7 Mar 2016 12:06:23 +0900 (JST) X-SecurityPolicyCheck: OK by SHieldMailChecker v2.4.6 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20160122 X-SHieldMailCheckerMailID: 03011874027f4aedba2bc74f2beb18ed To: "linux-btrfs@vger.kernel.org" From: Satoru Takeuchi Subject: [PATCH v2] Btrfs: Show a warning message if one of objectid reaches its highest value Message-ID: <56DCF015.9060703@jp.fujitsu.com> Date: Mon, 7 Mar 2016 12:05:57 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - It's better to show a warning message for the exceptional case that one of objectid (in most case, inode number) reaches its highest value. Show this message only once to avoid filling dmesg with it. - EOVERFLOW is more proper return value for this case. ENOSPC is for "No space left on device" case and objectid isn't related to any device. Signed-off-by: Satoru Takeuchi --- This patch can be applied to 4.5-rc7 --- fs/btrfs/inode-map.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c index e50316c..f5e3228 100644 --- a/fs/btrfs/inode-map.c +++ b/fs/btrfs/inode-map.c @@ -556,7 +556,15 @@ int btrfs_find_free_objectid(struct btrfs_root *root, u64 *objectid) mutex_lock(&root->objectid_mutex); if (unlikely(root->highest_objectid >= BTRFS_LAST_FREE_OBJECTID)) { - ret = -ENOSPC; + static bool __warned = false; + + if (unlikely(!__warned)) { + btrfs_warn(root->fs_info, + "The objectid of root %llu reaches its highest value.\n", + root->root_key.objectid); + __warned = true; + } + ret = -EOVERFLOW; goto out; }