From patchwork Thu Feb 20 11:04:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13983767 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 397CA1F4604 for ; Thu, 20 Feb 2025 11:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740049506; cv=none; b=WuCNfXjv+GjZSGl4fzQb3MLFRV/wgAVxQ9SoEBDeg4W7SgSzU/8TuQChLHiqBM7p9vblvee8k80x6332F9ZJdbFnYLa2K7TSMcSbTqnjTBxWK81xZIOiFF6zR1RPxXrdqndKg9z5PtJY9SlPY+Qgvz4EiqwEaNvJ9nd3i+KuPWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740049506; c=relaxed/simple; bh=Wyd5Wd89gnJUPIDlPqkGSgkK7n/wp64eKpdAMR3Jnzs=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dBfqOkBZuqJgkeovEpTXo668rdbknBxtriDJynCXmUfgo+arp5n3nq7RIBkGKNIN2T96gYLudo9A0D/oOaXLczTi1l1E3qyxXx2ztnajXjzVpCRdyrb+G9cQK3PNUh7L/KE0/KBpKMXpT2MZ3+IjjHmzBSW7ez2Qjwx4c8oziSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kCAMJgCA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kCAMJgCA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AECEC4CEE3 for ; Thu, 20 Feb 2025 11:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740049506; bh=Wyd5Wd89gnJUPIDlPqkGSgkK7n/wp64eKpdAMR3Jnzs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kCAMJgCAL1OGHn/otgY1v8GuS8ZK+7wmSkWzL3yacAhQUmID8BVo1t+sJ6N85xdyV EAAFkevTge4IXYRz/b/P9IyxY7EgFqFtcmzVt3Gav7E4rjqMrJ7glVoTEqdxhgFdY7 0O15QG/L7z1Xn6Y/jDifZVZiWINFMPy94X09YAyA/b3ZCYi1BsbDP1GbrRRCecD85x v7X3STxxOP4lR+s8g/cO7QQf8jFIjEIpJSJi5cQvOL9/HHv8gRH1ex73hOaRXo+Ej7 +ln2bUryQBsIdjHPNsmD9IAjHc6W8HQyjmBXePL3Yywg3GBy9D1UPLnK+f+fDlfOa/ zhOBvUHaVG1IQ== From: fdmanana@kernel.org To: linux-btrfs@vger.kernel.org Subject: [PATCH v2 18/30] btrfs: send: simplify return logic from record_new_ref() Date: Thu, 20 Feb 2025 11:04:31 +0000 Message-Id: <56ddd47f9ff5493137cc6ec668ff7b97413068b1.1740049233.git.fdmanana@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Filipe Manana There is no need to have an 'out' label and jump into it since there are no resource cleanups to perform (release locks, free memory, etc), so make this simpler by removing the label and goto and instead return directly. Signed-off-by: Filipe Manana --- fs/btrfs/send.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index b715557ec720..181a234e3a5e 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -4746,11 +4746,9 @@ static int record_new_ref(struct send_ctx *sctx) ret = iterate_inode_ref(sctx->send_root, sctx->left_path, sctx->cmp_key, 0, record_new_ref_if_needed, sctx); if (ret < 0) - goto out; - ret = 0; + return ret; -out: - return ret; + return 0; } static int record_deleted_ref(struct send_ctx *sctx)