| Message ID | 65fed3703d077362b9a7b3ec393452c40b6895db.1685411033.git.wqu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: small cleanups mostly for subpage cases | expand |
On Tue, May 30, 2023 at 09:45:28AM +0800, Qu Wenruo wrote: > In function end_bio_extent_readpage() we call > endio_readpage_release_extent() to unlock the extent io tree. > > However we pass PageUptodate(page) as @uptodate parameter for it, while > for previous end_page_read() call, we use a dedicated @uptodate local > variable. > > This is not a big deal, as even for subpage cases, either the bio only > covers part of the page, then the @uptodate is always false, and the > subpage ranges can still be merged. > > But for the sake of consistency, always use @uptodate variable when > possible. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On 30/5/23 09:45, Qu Wenruo wrote: > In function end_bio_extent_readpage() we call > endio_readpage_release_extent() to unlock the extent io tree. > > However we pass PageUptodate(page) as @uptodate parameter for it, while > for previous end_page_read() call, we use a dedicated @uptodate local > variable. > > This is not a big deal, as even for subpage cases, either the bio only > covers part of the page, then the @uptodate is always false, and the > subpage ranges can still be merged. > > But for the sake of consistency, always use @uptodate variable when > possible. > > Signed-off-by: Qu Wenruo <wqu@suse.com> LGTM Reviewed-by: Anand Jain <anand.jain@oracle.com> > --- > fs/btrfs/extent_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 9afdcf0c70dd..2d228cc8b401 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -745,7 +745,7 @@ static void end_bio_extent_readpage(struct btrfs_bio *bbio) > /* Update page status and unlock. */ > end_page_read(page, uptodate, start, len); > endio_readpage_release_extent(&processed, BTRFS_I(inode), > - start, end, PageUptodate(page)); > + start, end, uptodate); > > ASSERT(bio_offset + len > bio_offset); > bio_offset += len;
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 9afdcf0c70dd..2d228cc8b401 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -745,7 +745,7 @@ static void end_bio_extent_readpage(struct btrfs_bio *bbio) /* Update page status and unlock. */ end_page_read(page, uptodate, start, len); endio_readpage_release_extent(&processed, BTRFS_I(inode), - start, end, PageUptodate(page)); + start, end, uptodate); ASSERT(bio_offset + len > bio_offset); bio_offset += len;
In function end_bio_extent_readpage() we call endio_readpage_release_extent() to unlock the extent io tree. However we pass PageUptodate(page) as @uptodate parameter for it, while for previous end_page_read() call, we use a dedicated @uptodate local variable. This is not a big deal, as even for subpage cases, either the bio only covers part of the page, then the @uptodate is always false, and the subpage ranges can still be merged. But for the sake of consistency, always use @uptodate variable when possible. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)