diff mbox series

[1/3] btrfs-progs: libbtrfsutil/python: use MANIFEST.in for headers

Message ID 668010409411af3c06e2b6dda62f31fd9e54304d.1726885304.git.wqu@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs-progs: libbtrfsutil/python: fix all the warnings | expand

Commit Message

Qu Wenruo Sept. 21, 2024, 2:26 a.m. UTC
[BUG]
Currently with python3.12, the python bindding will always result the
following warning:

    [PY]     libbtrfsutil
/usr/lib/python3.12/site-packages/setuptools/_distutils/extension.py:134: UserWarning: Unknown Extension options: 'headers'
  warnings.warn(msg)

[CAUSE]
In the setup.py which specifies the files to be included into the package,
we use setuptools::Extension to specify the file lists and include paths.

But there is no handling of Extension::headers member, thus resulting the
above warning.

[FIX]
According to the docs of setuptools, MANIFEST.in is the file controlling
what files should be included.
So instead of the non-supported headers, use MANIFEST.in to include the
needed headers.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 libbtrfsutil/python/MANIFEST.in | 1 +
 libbtrfsutil/python/setup.py    | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)
 create mode 100644 libbtrfsutil/python/MANIFEST.in
diff mbox series

Patch

diff --git a/libbtrfsutil/python/MANIFEST.in b/libbtrfsutil/python/MANIFEST.in
new file mode 100644
index 000000000000..b613db8ea918
--- /dev/null
+++ b/libbtrfsutil/python/MANIFEST.in
@@ -0,0 +1 @@ 
+include btrfsutilpy.h
diff --git a/libbtrfsutil/python/setup.py b/libbtrfsutil/python/setup.py
index e0ffb7c52c5b..79c0b48dee7d 100755
--- a/libbtrfsutil/python/setup.py
+++ b/libbtrfsutil/python/setup.py
@@ -97,9 +97,6 @@  module = Extension(
         'qgroup.c',
         'subvolume.c',
     ],
-    headers=[
-        'btrfsutilpy.h'
-    ],
     include_dirs=['..'],
     library_dirs=['../..'],
     libraries=['btrfsutil'],