| Message ID | 668fba55-de0e-33d4-647d-44d6bec27aed@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 24, 2017 at 02:24:17PM +0900, Misono, Tomohiro wrote: > The value of 'verbose' is either 1 (default) or 0 (-q) > and "verbose >= 2" will not be true. > > After fix this, we get something like: > adding device /dev/sde id 2 > adding device /dev/sdf id 3 > during mkfs time when multiple devices are used. I think the original idea was to allow different levels of verbosity, and the "adding device" messages do not bring much value to be printed by default. The verbose/quiet options will be handled globally so this code will get cleaned at that time. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/mkfs/main.c b/mkfs/main.c index e405e5a2..c07cc1e1 100644 --- a/mkfs/main.c +++ b/mkfs/main.c @@ -1861,7 +1861,7 @@ int main(int argc, char **argv) error("unable to add %s to filesystem: %d", file, ret); goto out; } - if (verbose >= 2) { + if (verbose) { struct btrfs_device *device; device = container_of(fs_info->fs_devices->devices.next,
The value of 'verbose' is either 1 (default) or 0 (-q) and "verbose >= 2" will not be true. After fix this, we get something like: adding device /dev/sde id 2 adding device /dev/sdf id 3 during mkfs time when multiple devices are used. Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com> --- mkfs/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)